Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M120 public #210

Merged
merged 46 commits into from
Dec 5, 2023
Merged

M120 public #210

merged 46 commits into from
Dec 5, 2023

Commits on Nov 2, 2023

  1. Switch skia from canvaskit/0.38.2-1942-gab212df482 (m119) to canvaski…

    …t/0.38.2-2393-g746dbd8c61 (m120)
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e38d302 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c5d17a View commit details
    Browse the repository at this point in the history
  3. Bump to 120.0b4

    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f124252 View commit details
    Browse the repository at this point in the history
  4. m120: SkTypeface::UniqueID removed

    Milestone 120
    -------------
        `SkTypeface::UniqueID()` has been removed - clients should use the method instead of this static
        function.
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    027c66e View commit details
    Browse the repository at this point in the history
  5. m120: SkFont::refTypefaceOrDefault and SkFont::getTypefaceOrDefault()…

    … removed
    
    Milestone 120
    -------------
      * `SkFont::refTypefaceOrDefault` and `SkFont::getTypefaceOrDefault()` have been removed from the
        public API.
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    af7c172 View commit details
    Browse the repository at this point in the history
  6. m120: GrBackendSemaphore::initGL and GrBackendSemaphore::glSync removed

    Milestone 120
    -------------
      * `GrBackendSemaphore::initGL` and `GrBackendSemaphore::glSync` have been removed
        from the public API.
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d5d10f2 View commit details
    Browse the repository at this point in the history
  7. m120: GrDirectContext::MakeGL renamed to GrDirectContexts::MakeGL

    Milestone 120
    -------------
      * `GrDirectContext::MakeVulkan...` has been moved to `GrDirectContexts::MakeVulkan...` which are defined
        in `include/gpu/ganesh/vk/GrVkDirectContext.h`
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    355cf0c View commit details
    Browse the repository at this point in the history
  8. m120: prototype change of SkMipmapBuilder::attachTo

    Header diff:
    
    $ diff -u skia-m119/src/core/SkMipmapBuilder.h skia-m120/src/core/SkMipmapBuilder.h
    --- skia-m119/src/core/SkMipmapBuilder.h	2023-10-06 23:22:04.000000000 +0100
    +++ skia-m120/src/core/SkMipmapBuilder.h	2023-11-01 22:34:27.000000000 +0000
    @@ -27,7 +27,7 @@
          *  If these levels are compatible with src, return a new Image that combines src's base level
          *  with these levels as mip levels. If not compatible, this returns nullptr.
          */
    -    sk_sp<SkImage> attachTo(sk_sp<const SkImage> src);
    +    sk_sp<SkImage> attachTo(const sk_sp<const SkImage>& src);
    
     private:
         sk_sp<SkMipmap> fMM;
    HinTak committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    68881eb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    67de5f4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fc03eba View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    b4331dc View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    9039fbd View commit details
    Browse the repository at this point in the history
  2. Solving circular dependencies by listing twice

    The circular dependencies are only in Windows and Linux, from the OT-SVG hook.
    HinTak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    55f6d10 View commit details
    Browse the repository at this point in the history
  3. OT-SVG font test

    Comments on SVG test, and make it pass
    HinTak committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0d50241 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Reverting OT-SVG changes - simpler alternative to come.

    Revert "Patch to Hook up SkSVGOpenTypeSVGDecoder::Make to enable OT-SVG"
    
    This reverts commit 9039fbd.
    
    Revert "Solving circular dependencies by listing twice"
    
    This reverts commit 55f6d10.
    HinTak committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ae4f547 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e5f2e63 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Setting skia_enable_fontmgr_custom_empty=true on non-linux (its value…

    … defaults to skia_use_freetype &&)
    
    skia_use_freetype=true is not automatic with skia_enable_fontmgr_custom_empty=true
    
    Apparently it still tries to read headers from system locations on non-linux! Need skia_use_system_freetype2=false also.
    HinTak committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0f366c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95088fc View commit details
    Browse the repository at this point in the history
  3. Custom-load SVG font test

    Increase tolerance to make test_fontmgr_custom_svg_blob_bounds pass on windows
    HinTak committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f1f4feb View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Set link flag to -mmacosx-version-min=10.13 too, since we had compile…

    … flag = 10.13.
    
    This is a follow-up to an earlier change - we should keep compile-flag and link-flag
    minimum version in sync.
    
    commit ea0e2cd
    Author: Hin-Tak Leung <[email protected]>
    Date:   Fri Aug 4 06:50:32 2023 +0100
    
        CI failure log says Skia internals start to require Mac OS X 10.13.
    HinTak committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b0e3f3c View commit details
    Browse the repository at this point in the history
  2. These Image.* should have started working again with include/gpu/gane…

    …sh/SkImageGanesh.h
    
    These should have been part of the earlier commit
    (adding a misssing new header):
    
    commit deebf369ba0cdc1b2bc825e3ebbdbe0499377a3f
    Author: Jonathan Hogg <[email protected]>
    Date:   Mon Aug 14 14:50:21 2023 +0100
    
        Get `Image.MakeFromTexture` working again
    HinTak committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fb46ad4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4d9a8b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b314ef View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Test if shader is None, against segfaults

    Conflicts:
    	tests/test_shader.py
    HinTak committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3464d65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be99265 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    8c703dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37837f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddc1d57 View commit details
    Browse the repository at this point in the history
  4. m120: GrDirectContext::MakeVulkan... has been moved to `GrDirectCon…

    …texts::MakeVulkan...`
    
    Milestone 120
    -------------
    
      * `GrDirectContext::MakeVulkan...` has been moved to `GrDirectContexts::MakeVulkan...` which are defined
        in `include/gpu/ganesh/vk/GrVkDirectContext.h`
    HinTak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    0715b08 View commit details
    Browse the repository at this point in the history
  5. m118: Vulkan-specific calls are being removed from GrBackendSurface.h

    Adjust for recent m118/120 vulkan changes
    
    Milestone 118
    -------------
    
      * Vulkan-specific calls are being removed from GrBackendSurface.h. Clients should use the
        equivalents found in `include/gpu/ganesh/vk/GrVkBackendSurface.h"`
    HinTak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    20f7585 View commit details
    Browse the repository at this point in the history
  6. Re-enabling vulkan-related code, plus adjustments to m118/m120 changes

    GrBackendFormats::MakeVk now has an optional argument "willUseDRMFormatModifiers".
    HinTak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6240d5f View commit details
    Browse the repository at this point in the history
  7. m98: initVulkan and vkSemaphore are not defined unless the Vulkan bac…

    …kend is compiled in
    
    Milestone 98
    ------------
    
      * GrBackendSemaphore only includes methods that match the GPU backend that Skia was compiled for.
        For example, initVulkan and vkSemaphore are not defined unless the Vulkan backend is compiled
        into Skia.
    HinTak committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c6991de View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Missing vulkan/vulkan_core.h in CI - it was picking up from my own /u…

    …sr/include
    
    Locally, it is the "vulkan-headers" package.
    HinTak committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    18ae46d View commit details
    Browse the repository at this point in the history
  2. Vulkan headers in setup.py

    HinTak committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    21cb8ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    03ec32c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e693639 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Configuration menu
    Copy the full SHA
    094b230 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Configuration menu
    Copy the full SHA
    d09d27b View commit details
    Browse the repository at this point in the history
  2. README.m120.md

    HinTak committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b5f9882 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8fb7fd2 View commit details
    Browse the repository at this point in the history
  4. Bump up to 120b5

    HinTak committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9537cd2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0385881 View commit details
    Browse the repository at this point in the history
  6. Re-enabling - these tests started to work a while a go.

    The commit which disabled it, and the one which made it start to work, are below:
    
    commit 15dd24a
    Author: Hin-Tak Leung <[email protected]>
    Date:   Mon Jul 31 21:50:05 2023 +0100
    
        These attributes are not (yet) available under m116; may never be. RE-VISIT!!!
    
    commit 0a62144
    Author: Hin-Tak Leung <[email protected]>
    Date:   Tue Aug 1 04:43:05 2023 +0100
    
        m113: `SkImage::CompressionType` has been renamed to `SkTextureCompressionType`
    
        Milestone 113:
    
          * `SkImage::CompressionType` has been renamed to `SkTextureCompressionType` and moved to
            `include/core/SkTextureCompressionType.h`
    HinTak committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e8a5da1 View commit details
    Browse the repository at this point in the history
  7. mv README.m*.md relnotes/

    HinTak committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    78d6cc8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    03c661a View commit details
    Browse the repository at this point in the history
  9. typo

    HinTak committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d55eba0 View commit details
    Browse the repository at this point in the history