-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M127 public #251
M127 public #251
Conversation
…4875-gbe621ea042 on m126
…anvaskit/0.38.2-5214-g1c8089adff)
one too many m127: GrVkBackendContext -> skgpu::VulkanBackendContext
…iaSDLExample.cpp"
Make skia.GrDirectContexts (namespace) an alias to skia.GrDirectContext Make GrBackendRenderTargets (namespace) an alias to GrBackendRenderTarget Allow direct call to GrBackendRenderTargets::MakeGL
Adding direct call to SkSurfaces::WrapBackendRenderTarget Make Surface.Raster the same as Surface.MakeRaster
@kyamagu just FYI, the latest bunch of additions to the m127 pull are misc things I found while porting the official SDL2 skia example in google's repo (before they decided it is not particularly special and removed it) in c to python, and the additions basically allow newly written python code to look more like current upstream m1xx skia c API, instead of being stuck in looking like m87. (And the m87-like ones still works - and am just adding redirections, or direct calls to new, where old api was emulated with new). |
@kyamagu it looks like CI is failing because it can't get to the github centos host. I an assuming it is either a transient problem (e.g. Microsoft Windows is broken around the world at the moment) or a permanent one I.e. we need to switch to a newer Linux host. Will re-run the CI again later, and look at this again if it doesn't work after re-try. Don't worry. |
… 7 EOL on 1 Jul 2024 Upstream pull and issue: pypa/cibuildwheel#1917 pypa/cibuildwheel#1915
Centos 7 was EOL on 1st July 2024. Part of manylinux we used. Updating and hope it should be okay now. |
…yment target matches. We need and build for 10.13 in Skia. The default is 10.9, too low for us.
The m127 part is quite mundane - GrVkExtensionFlags were gone (withdrawn from public headers).
I have include the doc fix (#249) for apple shader compilation errors. Also while working on that, I found that it is good that old python code using m87-like API continues to work mostly, it is a bit confusing if one is looking at current m12x c code for reference (like trying to rewrite the sdl2 c example in python) , but having to go backward. So it would be nice to have newly written python code mimicking current c code API wise.
To that end, I found that while between m87 and m116,
SkSurfaceProps(inittype)
was removed, a simpler constructorSkSurfaceProps()
was added to replace it - when you just want "any" and don't care - and we simply commented out the removed one only. There are a few things I'd like to add, so that the python version of the sdl example mimic the c sdl example better. etc. So a few more things to add to this. This should build fine.