M129 public #260
Merged
M129 public #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bc61e2 to canvaskit/0.38.2-5698-gfb67954b7e
…vaskit/0.38.2-6080-gc4526a0f9c
…u/vk/GrVkTypes.h
See the diff:
$ diff -ruBb skia-m128/include/gpu/ganesh/vk/GrVkBackendSurface.h skia-m129/include/gpu/ganesh/vk/GrVkBackendSurface.h
--- skia-m128/include/gpu/ganesh/vk/GrVkBackendSurface.h 2024-08-10 19:16:09.000000000 +0100
+++ skia-m129/include/gpu/ganesh/vk/GrVkBackendSurface.h 2024-08-21 16:38:24.000000000 +0100
@@ -8,15 +8,19 @@
#ifndef GrVkBackendSurface_DEFINED
#define GrVkBackendSurface_DEFINED
-#include "include/gpu/vk/GrVkTypes.h"
-#include "include/gpu/vk/VulkanTypes.h"
#include "include/private/base/SkAPI.h"
+#include "include/private/gpu/vk/SkiaVulkan.h"
#include <string_view>
class GrBackendFormat;
class GrBackendTexture;
class GrBackendRenderTarget;
+struct GrVkImageInfo;
+
+namespace skgpu {
+struct VulkanYcbcrConversionInfo;
+}
namespace GrBackendFormats {
… -> canvaskit/0.38.2-6082-g07d7158eea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is just a small one-line vulkan include addition, besides the usual, to shift to m129.
Will pull in #258, #254 , and also a not-yet created pull for issue #259, before releasing m129 (or m130 if the m129 to m130 diff is small) when upstream m130 is out.