Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M129 public #260

Merged
merged 6 commits into from
Sep 20, 2024
Merged

M129 public #260

merged 6 commits into from
Sep 20, 2024

Conversation

HinTak
Copy link
Collaborator

@HinTak HinTak commented Aug 21, 2024

There is just a small one-line vulkan include addition, besides the usual, to shift to m129.

Will pull in #258, #254 , and also a not-yet created pull for issue #259, before releasing m129 (or m130 if the m129 to m130 diff is small) when upstream m130 is out.

…u/vk/GrVkTypes.h

See the diff:

$ diff -ruBb skia-m128/include/gpu/ganesh/vk/GrVkBackendSurface.h skia-m129/include/gpu/ganesh/vk/GrVkBackendSurface.h
--- skia-m128/include/gpu/ganesh/vk/GrVkBackendSurface.h	2024-08-10 19:16:09.000000000 +0100
+++ skia-m129/include/gpu/ganesh/vk/GrVkBackendSurface.h	2024-08-21 16:38:24.000000000 +0100
@@ -8,15 +8,19 @@
 #ifndef GrVkBackendSurface_DEFINED
 #define GrVkBackendSurface_DEFINED

-#include "include/gpu/vk/GrVkTypes.h"
-#include "include/gpu/vk/VulkanTypes.h"
 #include "include/private/base/SkAPI.h"
+#include "include/private/gpu/vk/SkiaVulkan.h"

 #include <string_view>

 class GrBackendFormat;
 class GrBackendTexture;
 class GrBackendRenderTarget;
+struct GrVkImageInfo;
+
+namespace skgpu {
+struct VulkanYcbcrConversionInfo;
+}

 namespace GrBackendFormats {
This was referenced Sep 17, 2024
@HinTak HinTak merged commit 3feea08 into kyamagu:main Sep 20, 2024
13 checks passed
@HinTak HinTak deleted the m129-public branch September 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant