Skip to content

Conversation

MichalKalke
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Adjust docs for buildless

Related issue(s)


## Changes

- The internal Docker Registry is no longer part of the Serverless module. Instead, the Docker Registry is now a separate, standalone module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the bullet points so that it explains what would happen if user switches it on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@MichalKalke MichalKalke force-pushed the adjust-docs-for-buildless branch from 2f97a37 to cfc39ae Compare July 25, 2025 08:20
@MichalKalke MichalKalke marked this pull request as ready for review October 16, 2025 08:06
@MichalKalke MichalKalke requested a review from a team as a code owner October 16, 2025 08:06
@MichalKalke MichalKalke force-pushed the adjust-docs-for-buildless branch from 02d0978 to 870507e Compare October 16, 2025 08:32
@MichalKalke MichalKalke enabled auto-merge (squash) October 16, 2025 08:57
- Override the default build Job preset.
- Override the default runtime Pod preset.
- Override the default log level.
- Override the default log format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the

- Enable buildless mode of Serverless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted


## What would change if I switch buildldess on

- Your Serverless module will no longer include an internal Docker Registry. You will need to use a separate, standalone Docker Registry module instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the Docker Registry module is an internal module for our SKR users. Does it mean it will be available to everyone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know you can use Docker Registry on stage (it is in experimental channel) I don't know when/if it will be promoted to next stages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking because we'll also have to update the help portal docs, and as you said, it's only available on the experimental channel. Does this mean we should not mention this on the help portal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we're a bit confused here — I meant that the new buildless serverless does not have a built-in Docker Registry (unlike the legacy version), which is now a standalone community module. I've removed the misleading sentence, so there's no need to update the Help Portal documentation anywhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a white background to the diagram.
Some of the elements are not rendered properly. They're all black, which might make them look bad in dark mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added


## What would change if I switch buildldess on

- Your Serverless module will no longer include an internal Docker Registry. You will need to use a separate, standalone Docker Registry module instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking because we'll also have to update the help portal docs, and as you said, it's only available on the experimental channel. Does this mean we should not mention this on the help portal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants