-
Notifications
You must be signed in to change notification settings - Fork 25
Adjust docs for buildless #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adjust docs for buildless #1765
Conversation
|
||
## Changes | ||
|
||
- The internal Docker Registry is no longer part of the Serverless module. Instead, the Docker Registry is now a separate, standalone module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the bullet points so that it explains what would happen if user switches it on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
2f97a37
to
cfc39ae
Compare
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Krzysztof Kwiatosz <[email protected]>
Co-authored-by: Krzysztof Kwiatosz <[email protected]>
02d0978
to
870507e
Compare
- Override the default build Job preset. | ||
- Override the default runtime Pod preset. | ||
- Override the default log level. | ||
- Override the default log format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the
- Enable buildless mode of Serverless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted
docs/user/technical-reference/07-20-function-processing-stages.md
Outdated
Show resolved
Hide resolved
|
||
## What would change if I switch buildldess on | ||
|
||
- Your Serverless module will no longer include an internal Docker Registry. You will need to use a separate, standalone Docker Registry module instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, the Docker Registry module is an internal module for our SKR users. Does it mean it will be available to everyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know you can use Docker Registry on stage (it is in experimental channel) I don't know when/if it will be promoted to next stages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking because we'll also have to update the help portal docs, and as you said, it's only available on the experimental channel. Does this mean we should not mention this on the help portal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we're a bit confused here — I meant that the new buildless serverless
does not have a built-in Docker Registry (unlike the legacy version), which is now a standalone community module. I've removed the misleading sentence, so there's no need to update the Help Portal documentation anywhere else.
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
Co-authored-by: Grzegorz Karaluch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a white background to the diagram.
Some of the elements are not rendered properly. They're all black, which might make them look bad in dark mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added
|
||
## What would change if I switch buildldess on | ||
|
||
- Your Serverless module will no longer include an internal Docker Registry. You will need to use a separate, standalone Docker Registry module instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking because we'll also have to update the help portal docs, and as you said, it's only available on the experimental channel. Does this mean we should not mention this on the help portal?
Description
Changes proposed in this pull request:
Related issue(s)