Skip to content

makefile cleanup #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

makefile cleanup #93

wants to merge 4 commits into from

Conversation

@Disper
Copy link
Member

@Disper Disper commented Oct 10, 2025 •
edited
Loading

  • Attempts to clean-up Makefiles that contains targets related to provisioner and the ancient way of building the image

@Disper Disper requested a review from a team as a code owner October 10, 2025 06:31
@Disper Disper requested a review from a team as a code owner October 10, 2025 10:04
koala7659
koala7659 previously approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Disper Disper dismissed koala7659’s stale review October 14, 2025 08:39

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koala7659 koala7659 koala7659 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Disper @koala7659