Fix variable length arrays warning in waves2amr - #1774
Merged
Conversation
jrood-nrel
approved these changes
Oct 28, 2025
marchdf
marked this pull request as ready for review
October 28, 2025 15:58
marchdf
enabled auto-merge (squash)
October 28, 2025 15:58
mbkuhn
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have the following
warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]. Basically waves2amr is using variable length arrays (!): basically for 2 variables n0 and n1, it doesdouble out[n0*n1]. Which is fun and cool, but also not great (as in this is valid C99 but not in the C++ standard) A companion PR fixes this (kynema/Waves2AMR#8) but it comes with an API update, this PR.Don't merge this PR until we've updated the submod here when the other PR is merged.
Pull request type
Please check the type of change introduced:
Checklist
This PR was tested by running: