Load CountryData from CSV#2
Open
sammacbeth wants to merge 6 commits intokyotoprotocol:developmentfrom
Open
Conversation
added 6 commits
August 2, 2012 14:41
…d in MongoDB. The new COUNTRIES parameter accepts a comma separated list of ISO country codes. Data is then loaded from the countrydata.csv file for the countries defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of pulling data from a MongoDB, use a CSV file with data for all countries, then sub-select the countries to use as agents from this data. This method has the following advantages:
The attached changeset makes the required changes to load country data from a csv file and uses this file as the data source. There is also some basic unittesting of the new code.
Let me know if these changes seem reasonable.
Sam.