Skip to content

Make max_speakers configurable within the json config#410

Merged
gabrieldemarmiesse merged 4 commits into
mainfrom
make_max_speakers_configurable
Apr 15, 2026
Merged

Make max_speakers configurable within the json config#410
gabrieldemarmiesse merged 4 commits into
mainfrom
make_max_speakers_configurable

Conversation

@gabrieldemarmiesse

Copy link
Copy Markdown
Collaborator

Checklist

  • Read CONTRIBUTING.md, and accept the CLA by including the provided snippet. We will not accept PR without this.
  • Run pre-commit hook.
  • If you changed Rust code, run cargo check, cargo clippy, cargo test.

PR Description

Comment thread moshi/moshi/models/tts.py Outdated
lm=lm, mimi=mimi, tokenizer=tokenizer,
voice_suffix=voice_suffix, voice_repo=voice_repo,
machine=machine, delay_steps=delay_steps, multistream=multistream,
max_speakers=checkpoint_info.raw_config.get('max_speakers', DEFAULT_MAX_SPEAKERS),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to have in in checkpoint_info.tts_config instead (need to move key in json)

@gabrieldemarmiesse gabrieldemarmiesse marked this pull request as ready for review April 15, 2026 08:36

@adefossez adefossez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@gabrieldemarmiesse gabrieldemarmiesse merged commit d0d786b into main Apr 15, 2026
9 checks passed
@gabrieldemarmiesse gabrieldemarmiesse deleted the make_max_speakers_configurable branch April 15, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants