macOS: use YUYV for certain pixel types #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange kCVPixelFormatType_420YpCbCr8BiPlanarFullRange kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange Fixes #100. This was suggested by the code from @paviro at #100 (comment).
Yep, I'll merge this and release 0.10.8 once I get home. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, use YUYV for the following pixel types:
kCVPixelFormatType_420YpCbCr10BiPlanarVideoRangekCVPixelFormatType_420YpCbCr8BiPlanarFullRangekCVPixelFormatType_420YpCbCr8BiPlanarVideoRangeFixes #100, at least for me (M1 Macbook Pro).
This was suggested by the work of @paviro at
#100 (comment). (Thanks!)
@l1npengtul this is a small patch on the 0.10 branch. Any chance you could merge it and make a quick 0.10.6 release in the meantime before 0.11 arrives? I have been testing this for a couple months on macOS and it has been working fine for me. Thanks for this useful crate!