Pr 364 followup (OpenBeta#367)

* fix: build break
* don't push docker img on pr
* forgot to uncomment original code

.github/workflows/nodejs.yml

@@ -14,7 +14,7 @@ jobs:
   # deploy to staging by commiting to api-server-deployment repo
   deploy-staging:
     runs-on: ubuntu-22.04
-    # if: github.ref_name == 'develop'
+    if: github.ref_name == 'develop'
     needs: docker
     steps:
       - name: 'Checkout Project'

.vscode/launch.json

@@ -44,6 +44,18 @@
             ],
             "console": "integratedTerminal",
         },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "Launch API Server (serve-dev)",
+            "skipFiles": ["<node_internals>/**"],
+            "program": "${workspaceFolder}/src/main.ts",
+            "preLaunchTask": "tsc: build - tsconfig.json",
+            "outFiles": ["${workspaceFolder}/build/**/*.js"],
+            "runtimeExecutable": "yarn",
+            "runtimeArgs": ["run", "serve-dev"],
+            "console": "integratedTerminal"
+          },
         {
             "name": "Debug Jest Tests",
             "type": "node",

package.json

@@ -71,6 +71,7 @@
     "build-release": "tsc  -p tsconfig.release.json",
     "clean": "tsc -b --clean && rm -rf build/*",
     "serve": "yarn build && node --experimental-json-modules build/main.js",
+    "serve-dev": "GOD_MODE=true yarn serve",
     "refresh-db": "./refresh-db.sh",
     "seed-usa": "yarn build && node build/db/import/usa/USADay0Seed.js",
     "seed-db": "./seed-db.sh",

src/auth/middleware.ts

@@ -1,37 +1,47 @@
-import muid from 'uuid-mongodb'
+import muid, { MUUID } from 'uuid-mongodb'
+import { logger } from '../logger.js'
 import { AuthUserType } from '../types.js'
 import { verifyJWT } from './util.js'
-import { logger } from '../logger.js'
 
 /**
  * Create a middleware context for Apollo server
  */
-export const createContext = async ({ req }): Promise<any> => {
-  const { headers } = req
+export const createContext = (() => {
+  let testUUID: MUUID
 
-  const user: AuthUserType = {
-    roles: [],
-    uuid: undefined,
-    isBuilder: false
+  if (process.env.GOD_MODE === 'true') {
+    testUUID = muid.v4()
+    logger.info('🚨🚨 GOD_MODE enabled, allowing all queries and mutations. This is ONLY for local development and should NOT happen production. 🚨🚨')
+    logger.info(`The user.uuid for this session is: ${testUUID.toString()}`)
   }
 
-  const authHeader = String(headers?.authorization ?? '')
-  if (authHeader.startsWith('Bearer ')) {
-    const token = authHeader.substring(7, authHeader.length).trim()
+  //  return async ({ req }: { req?: Request } = {}): Promise<any> => {
+  //    const headers = req?.headers
+  return async ({ req }): Promise<any> => {
+    const { headers } = req
 
-    let payload
-    try {
-      payload = await verifyJWT(token)
-    } catch (e) {
-      logger.error(`Can't verify JWT token ${e.toString() as string}`)
-      throw new Error('An unexpected error has occurred.  Please notify us at [email protected].')
+    const user: AuthUserType = {
+      roles: [],
+      uuid: undefined,
+      isBuilder: false
     }
 
-    user.isBuilder = payload?.scope?.includes('builder:default') ?? false
-    user.roles = payload?.['https://tacos.openbeta.io/roles'] ?? []
-    const uidStr: string | undefined = payload?.['https://tacos.openbeta.io/uuid']
-    user.uuid = uidStr != null ? muid.from(uidStr) : undefined
-  }
+    if (process.env.GOD_MODE === 'true' && (user.uuid == null)) {
+      user.roles = ['user_admin', 'org_admin', 'editor']
+      user.uuid = testUUID
+      logger.info(`The user.roles for this session is: ${user.roles.toString()}`)
+    } else {
+      const authHeader = String(headers.authorization ?? '')
+      if (authHeader.startsWith('Bearer ')) {
+        const token = authHeader.substring(7, authHeader.length).trim()
+        const z = await verifyJWT(token)
 
-  return { user }
-}
+        user.isBuilder = z?.scope?.includes('builder:default') ?? false
+        user.roles = z?.['https://tacos.openbeta.io/roles'] ?? []
+        const uidStr: string | undefined = z?.['https://tacos.openbeta.io/uuid']
+        user.uuid = uidStr != null ? muid.from(uidStr) : undefined
+      }
+    }
+    return { user }
+  }
+})()

src/auth/permissions.ts

@@ -1,9 +1,10 @@
-import { shield, allow, and, or } from 'graphql-shield'
-import { isEditor, isUserAdmin, isOwner, isValidEmail, isMediaOwner } from './rules.js'
+import { shield, allow, or, and } from 'graphql-shield'
+import { isEditor, isUserAdmin, isOwner, isBuilderServiceAccount, isValidEmail } from './rules.js'
 
-const permissions = shield({
+const normalPermissions = {
   Query: {
-    '*': allow
+    '*': allow,
+    getUserProfile: or(isOwner, isBuilderServiceAccount)
   },
   Mutation: {
     addOrganization: isUserAdmin,
@@ -13,14 +14,25 @@ const permissions = shield({
     updateArea: isEditor,
     updateClimbs: isEditor,
     deleteClimbs: isEditor,
-    updateUserProfile: and(isOwner, isValidEmail),
-    addEntityTag: or(isMediaOwner, isUserAdmin),
-    removeEntityTag: or(isMediaOwner, isUserAdmin),
-    addMediaObjects: or(isOwner),
-    deleteMediaObject: or(isMediaOwner, isUserAdmin)
+    updateUserProfile: and(isOwner, isValidEmail)
+  }
+}
+
+// permissions object for when env var GOD_MODE is true
+// only relevant for local development via `yarn serve-dev`
+const godModePermissions = {
+  Query: {
+    '*': allow
+  },
+  Mutation: {
+    '*': allow
   }
-},
-{
+}
+
+// determine which permissions object to use based on env var GOD_MODE
+const permissionsToUse = process.env.GOD_MODE === 'true' ? godModePermissions : normalPermissions
+
+const permissions = shield(permissionsToUse, {
   allowExternalErrors: true,
   fallbackRule: allow
 })