web: fix MeshCore ghost nodes (stale contact enrichment discarded)#841
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A node first heard via a bare MeshCore ADVERTISEMENT is upserted as a placeholder stamped lastHeard = now (receiver wall clock). The follow-up roster contact record carries lastHeard = last_advert — the sender-stamped advert-creation time, always older (seconds for healthy clocks, years for broken ones) — so upsert_node's row-level freshness guard discarded the entire named update, permanently: every contact re-post (auto-update re-fetch, periodic snapshot, restart) is also sender-stamped, while each advertised-position ingest re-bumps the row's last_heard. Result: nameless "ghost" nodes with hex short names, NULL role (displayed as the CLIENT default), and advert-stamped position_time — 22 of 48 meshcore nodes on dweb at the time of diagnosis.
Fix (web-side, protocol-neutral): after the guarded upsert, a non-synthetic record additionally fills identity columns that are still NULL (num, short_name, long_name, macaddr, hw_model, role, public_key, is_unmessagable). Stale records can fill gaps but never overwrite fresher values; synthetic chat placeholders remain barred from real rows; an empty MeshCore adv_name never fills long_name (NULLIF).