Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for learning capabilities with torchpme #104

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Conversation

E-Rum
Copy link
Contributor

@E-Rum E-Rum commented Dec 11, 2024

No description provided.

Copy link

github-actions bot commented Dec 11, 2024

Here is the build version of the cookbook in this pull request: documentation.zip, you can view it locally by unzipping documentation.zip and open the index.html with your favorite browser.

@DavideTisi
Copy link
Collaborator

is it ready for review?

@E-Rum
Copy link
Contributor Author

E-Rum commented Feb 9, 2025

Yes!

@DavideTisi DavideTisi self-requested a review February 9, 2025 23:17
Copy link
Collaborator

@DavideTisi DavideTisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added few modifications to the titles. Look if you like it, if so you can merge. Given that the CI passes.

@DavideTisi
Copy link
Collaborator

Ah in principle this notebook would be too long. We said no more than 10 min on CI, but the results in the figures really show that the number of epochs is necessary to see the correct behaviour of the charge so for me it is ok

@ceriottm
Copy link
Contributor

Ah in principle this notebook would be too long. We said no more than 10 min on CI, but the results in the figures really show that the number of epochs is necessary to see the correct behaviour of the charge so for me it is ok

Ackshually I think for the paper we showed that picking a better learning rate cut the epochs by 10, @E-Rum can you update so it doesn't take forever?

@DavideTisi
Copy link
Collaborator

Screenshot 2025-02-10 alle 11 25 07

Just make the X axis the same like put sharexaxis=True instead of False

@E-Rum
Copy link
Contributor Author

E-Rum commented Feb 10, 2025

Ok, now it's only ~3m. Please give a thumbs up to this message if it works now, and I'll merge

@E-Rum E-Rum requested a review from DavideTisi February 10, 2025 10:40
@DavideTisi DavideTisi merged commit 46ba137 into main Feb 10, 2025
17 checks passed
@DavideTisi DavideTisi deleted the torchpme branch February 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants