Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize label\shape.py #1460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Optimize label\shape.py #1460

wants to merge 2 commits into from

Conversation

PairZhu
Copy link
Contributor

@PairZhu PairZhu commented Jun 18, 2024

Optimized the rendering logic of shapes so that the thickness of shape lines and crosshair remains consistent on the screen regardless of the zoom level.

Additionally, another advantage is that shapes do not become distorted when the x and y axes have different scaling ratios (this is useful in my project, but such a requirement is uncommon, so the related changes have not been uploaded).

@PairZhu
Copy link
Contributor Author

PairZhu commented Jun 18, 2024

The first CI failure doesn't seem to be caused by my code, can you check the cause? @wkentaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant