fix: prevent file descriptor leak in API mode#119
Merged
Conversation
…dles Cache Nvml, System, and Disks instances instead of recreating them on every metrics collection iteration, preventing FD exhaustion in long-running API server processes. - Store Nvml handle in NvidiaGpuReader with graceful reinit on failure - Reuse sysinfo::System across get_process_info() calls - Create Disks once before the API loop and refresh in-place each cycle - Remove now-unused standalone get_gpu_processes() function Closes #118
inureyes
added
type:enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nvmlhandle inNvidiaGpuReaderand reuse acrossget_gpu_info()/get_process_info()calls, with graceful reinit on handle invalidation (e.g., GPU hot-unplug)sysinfo::Systeminstance acrossget_process_info()calls instead of creating a new one every iterationDisksinstance once before the API metrics collection loop and refresh in-place each cycle viadisks.refresh(true)Test plan
cargo buildpassescargo clippypasses with no warningsls /proc/<pid>/fd | wc -lCloses #118