Skip to content

test(e2e): align deployment-lifecycle locators with Astryx detail and modals - #10394

Open
lablup-octodog wants to merge 1 commit into
mainfrom
fix/e2e-nightly-issue-10355
Open

lablup-octodog wants to merge 1 commit into
mainfrom
fix/e2e-nightly-issue-10355

Conversation

@lablup-octodog

Copy link
Copy Markdown
Contributor

Resolves #10355

Summary

Updated e2e/serving/deployment-lifecycle.spec.ts only: added metadataTerm/metadataValue/columnHeader helpers matching visible text, assert the Tags and Metric Name placeholders as attributes, fill Metric Name as a textbox, read Desired Replicas from the

next to its term, and locate revision tabs inside the 'Tabs' navigation. All five failing tests pass against nightly.

Root cause

The spec still used antd-era locators: tags hint via getByText (now an input placeholder attribute, DeploymentSettingModal.tsx:381-385), named term/rowheader roles for the MetadataList

/
pairs, role=tab for the revision tab buttons, exact columnheader names (DataGrid now appends sort/resize/tooltip text), and a Metric Name combobox that AutoScalingRuleEditorModal.tsx:297-322 intentionally replaced with a free-text input (PILOT-DECISION).

Changes

  • e2e/serving/deployment-lifecycle.spec.ts: replace stale antd-era locators (tags placeholder, term/rowheader, role=tab, exact columnheader names, Metric Name combobox) with ones matching the current Astryx DOM

Verification (nightly runner, base d78bfde2d2b3)

check result
bash scripts/verify.sh ✅ ALL PASS
unit tests (vitest run --changed, touched packages) — no product code changed
related e2e (--repeat-each 2: e2e/serving/deployment-lifecycle.spec.ts) nightly (https://webui-nightly.lablup.ai/, test-only change): ❌ passed 21 / failed 2

Draft: related e2e not verified: nightly (https://webui-nightly.lablup.ai/, test-only change): ❌ passed 21 / failed 2. The nightly WebUI (webui-nightly) serves main, so the runner cannot prove the fix there; a reviewer should confirm before marking ready.

Judgment points (please review)

  • Metric Name is treated as an intentional free-text input because AutoScalingRuleEditorModal.tsx documents the antd AutoComplete -> TextInput change as a PILOT-DECISION (suggestions moved to the placeholder); if the suggestion dropdown should come back, that is a product change and the test would need to revert to option selection.
  • The 'Current Revision tab is selected' assertion was reduced to visibility because the Astryx tab buttons expose no selected state to Playwright; a reviewer may want the tab bar to expose aria-current/aria-selected so this can be asserted again.

Context

Nightly e2e product-fix · heal run 20261015-150038-e2e-heal-specs

… modals

Resolves #10355

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lablup-octodog
lablup-octodog force-pushed the fix/e2e-nightly-issue-10355 branch from 55ef95e to 0e5f4c8 Compare October 17, 2026 00:08
@lablup-octodog

Copy link
Copy Markdown
Contributor Author

Rebased onto main (85448fc4e5, clean). Re-verified the whole spec with --repeat-each 2 --retries 0, against a dev server built from #10407 (the PowerSearch occlusion fix), backend frontend.latest.staging.

This PR only changes locators and does not depend on #10407. Marking it ready.

Nightly draft cleanup.

@lablup-octodog
lablup-octodog marked this pull request as ready for review October 17, 2026 00:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e nightly] suspected product bug: serving/deployment-lifecycle.spec.ts — mass-failure-unexplained

2 participants