Skip to content

test(e2e): heal session scheduling history spec for the Astryx UI - #10400

Open
lablup-octodog wants to merge 1 commit into
mainfrom
fix/e2e-nightly-issue-10349
Open

lablup-octodog wants to merge 1 commit into
mainfrom
fix/e2e-nightly-issue-10349

Conversation

@lablup-octodog

Copy link
Copy Markdown
Contributor

Resolves #10349

Summary

Rewrote the spec's locators against the current UI. The drawer opens by clicking the mocked session name button. The Status entry is found as a MetadataList term/definition. Filters go through the PowerSearch typeahead ('Search filters'), the Field/Operator/Value editor popover and the Apply button, and are asserted via the token's 'Remove : ...' button. Datetime filters use the 'Open calendar' button and the 'Choose date' grid. The refresh button is now 'Refresh'. The enqueue row is matched by text, and collapse re-clicks the single 'Expand row' toggle. The backdrop-dismiss test became an Escape-dismiss test because SessionSchedulingHistoryModal is variant='fullscreen' since #9048 and has no reachable backdrop.

Root cause

The product works: the history button sits next to the Status badge in SessionDetailContent.tsx:417 with the accessible name 'Session Scheduling History'. The spec still targeted antd-era DOM (tr.ant-table-row, '.ant-space-compact .ant-select', '.ant-picker', '.ant-tag', '.ant-modal-wrap', a 'history'-named button, a Status table row), all gone after the Astryx migration and #9048, so openSessionDetailDrawer timed out before any assertion.

Changes

  • e2e/session/session-scheduling-history-modal.spec.ts: replace antd selectors with role-based Astryx/PowerSearch/DataGrid locators, add selectFilterProperty/applyFilterValue/getFilterTokenRemoveButton helpers, parametrize the Created At/Updated At date picker and apply tests, replace backdrop dismissal with Escape dismissal

Verification (nightly runner, base d78bfde2d2b3)

check result
bash scripts/verify.sh ✅ ALL PASS
unit tests (vitest run --changed, touched packages) — no product code changed
related e2e (--repeat-each 2: e2e/session/session-scheduling-history-modal.spec.ts) nightly (https://webui-nightly.lablup.ai/, test-only change): ❌ passed 16 / failed 2

Draft: related e2e not verified: nightly (https://webui-nightly.lablup.ai/, test-only change): ❌ passed 16 / failed 2. The nightly WebUI (webui-nightly) serves main, so the runner cannot prove the fix there; a reviewer should confirm before marking ready.

Judgment points (please review)

Context

Nightly e2e product-fix · heal run 20261015-150038-e2e-heal-specs

Resolves #10349

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lablup-octodog
lablup-octodog force-pushed the fix/e2e-nightly-issue-10349 branch from ca9eef8 to 7cbce22 Compare October 17, 2026 00:08
@lablup-octodog

Copy link
Copy Markdown
Contributor Author

Rebased onto main (85448fc4e5, clean). Re-verified the whole spec with --repeat-each 2 --retries 0, against a dev server built from #10407 (the PowerSearch occlusion fix), backend frontend.latest.staging: 48/48 passed.

The two failures in the earlier runner verification came from the filter-chip remove (x) being covered by the clear-all lane (#10289 / #10352). #10407 fixes that.

Marking this ready. Merge it after #10407. Before that fix lands, the chip-remove steps still fail against main.

Nightly draft cleanup.

@lablup-octodog
lablup-octodog marked this pull request as ready for review October 17, 2026 00:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e nightly] suspected product bug: session/session-scheduling-history-modal.spec.ts — post-9048-spec-mismatch

2 participants