Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Hyperaccel LPU devices #2134

Merged
merged 25 commits into from
Apr 5, 2024
Merged

feat: add support for Hyperaccel LPU devices #2134

merged 25 commits into from
Apr 5, 2024

Conversation

kyujin-cho
Copy link
Member

This PR updates webui to support querying, altering and attaching Hyperaccel LPU devices.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@kyujin-cho kyujin-cho requested a review from inureyes January 8, 2024 05:12
@kyujin-cho kyujin-cho self-assigned this Jan 8, 2024
@github-actions github-actions bot added the size:XL 500~ LoC label Jan 8, 2024
@kyujin-cho kyujin-cho added this to the 24.03 milestone Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 3.11% 117/3763
🔴 Branches 3.53% 87/2466
🔴 Functions 1.53% 19/1244
🔴 Lines 3.06% 113/3690

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from a55184d

@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2134.d3g9cs6u59b8lw.amplifyapp.com

@inureyes inureyes added type:enhance Add new features effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:4 As soon as feasible, implementation is essential. platform:general area:impl Implementation issue. impact:visible This change is visible to users. comp:manager Related to Manager component labels Jan 19, 2024
inureyes
inureyes requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device icon needs to change from furious to hyperaccel icon.

rapsealk
rapsealk reviewed Jan 23, 2024
View reviewed changes
@github-actions github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Mar 28, 2024
lizable
lizable reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some missing translations, and minor icon matching. Except that, it's okay to merge.

@github-actions github-actions bot added field:localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Mar 28, 2024
@lizable lizable self-requested a review March 28, 2024 08:30
lizable
lizable approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw we'd better add those AI accelerators(including Hyperaccel LPU and others) into resource policy as well.

lizable
lizable approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@inureyes
Copy link
Member

inureyes commented Apr 5, 2024

LGTM.

We need to continue #1937 ( ref. @lizable @kyujin-cho @agatha197 )

@inureyes inureyes merged commit b1bb97f into main Apr 5, 2024
8 checks passed
@inureyes inureyes deleted the feature/lpu-support branch April 5, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

@lizable lizable lizable approved these changes

@rapsealk rapsealk Awaiting requested review from rapsealk

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@kyujin-cho kyujin-cho

Labels
area:impl Implementation issue. comp:manager Related to Manager component effort:normal Need to understand a few modules / some extent of contextual or historical information. field:localization field:UI / UX impact:visible This change is visible to users. platform:general size:XL 500~ LoC type:enhance Add new features urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
5 participants
@kyujin-cho @inureyes @yomybaby @rapsealk @lizable