-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Hyperaccel LPU devices #2134
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 3.11% | 117/3763 |
🔴 | Branches | 3.53% | 87/2466 |
🔴 | Functions | 1.53% | 19/1244 |
🔴 | Lines | 3.06% | 113/3690 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from a55184d
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device icon needs to change from furious to hyperaccel icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some missing translations, and minor icon matching. Except that, it's okay to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Btw we'd better add those AI accelerators(including Hyperaccel LPU and others) into resource policy as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
LGTM. We need to continue #1937 ( ref. @lizable @kyujin-cho @agatha197 ) |
This PR updates webui to support querying, altering and attaching Hyperaccel LPU devices.
Checklist: (if applicable)