Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports cuda.mem virtual resource slot #2484

Closed

Conversation

yomybaby
Copy link
Member

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:L 100~500 LoC label Jun 19, 2024
Copy link
Member Author

yomybaby commented Jun 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Jun 19, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
2.83% (+0.01% 🔼)
140/4944
🔴 Branches
3.01% (-0% 🔻)
101/3361
🔴 Functions
1.66% (+0.01% 🔼)
27/1625
🔴 Lines
2.7% (+0.01% 🔼)
131/4854
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / MultipleTypeInputWithSlider.tsx
0% 0% 0% 0%

Test suite run success

51 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 5cf6cf4

@yomybaby yomybaby force-pushed the feature/supports-cuda.mem branch 2 times, most recently from 5cf6cf4 to 3eb46d5 Compare June 19, 2024 09:41
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Jun 19, 2024
@yomybaby yomybaby force-pushed the feature/supports-cuda.mem branch 2 times, most recently from b7b17c8 to 19b7cf1 Compare June 19, 2024 09:58
@yomybaby yomybaby force-pushed the feature/supports-cuda.mem branch from 19b7cf1 to 81dfa1b Compare June 19, 2024 10:16
@yomybaby yomybaby changed the base branch from main to feature/use-resource-slot-details June 19, 2024 10:16
@github-actions github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Jun 19, 2024
@yomybaby yomybaby force-pushed the feature/use-resource-slot-details branch from 7ab7cb4 to 6b32b37 Compare June 19, 2024 10:28
@yomybaby yomybaby mentioned this pull request Jun 19, 2024
6 tasks
@yomybaby yomybaby closed this Jun 19, 2024
@yomybaby
Copy link
Member Author

This PR is duplicated by #2486. (However, I will keep #2486 and close this one.)

@yomybaby yomybaby deleted the feature/supports-cuda.mem branch December 13, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant