Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: draft for model player UI derived from WebUI #2719

Closed
wants to merge 1 commit into from

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Sep 23, 2024

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Sep 23, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

lizable commented Sep 23, 2024

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Sep 23, 2024
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch from 9443c5b to 464b6e5 Compare September 23, 2024 10:32
@agatha197 agatha197 force-pushed the feature/model-player-UI branch from fb41c6a to 0de0ff5 Compare September 23, 2024 10:32
@agatha197 agatha197 changed the base branch from feature/import-and-start-service-from-hugging-face-and-show-result-with-modal to graphite-base/2719 September 23, 2024 11:01
@agatha197 agatha197 force-pushed the feature/model-player-UI branch from 0de0ff5 to 3b1df99 Compare September 23, 2024 11:02
@agatha197 agatha197 changed the base branch from graphite-base/2719 to main September 23, 2024 11:03
@agatha197 agatha197 force-pushed the feature/model-player-UI branch from 3b1df99 to 865229f Compare September 23, 2024 11:03
@lizable lizable force-pushed the feature/model-player-UI branch from 865229f to 652eba3 Compare November 25, 2024 10:06
@lizable
Copy link
Contributor Author

lizable commented Nov 25, 2024

closing this PR for unknown render fails after merging conflicts from main branch and continue this issue in #2878

@lizable lizable closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants