fix: make protos — Makefile and proto generation fixes#17
Closed
dinoallo wants to merge 6 commits intorelease/1.7+labringfrom
Closed
fix: make protos — Makefile and proto generation fixes#17dinoallo wants to merge 6 commits intorelease/1.7+labringfrom
dinoallo wants to merge 6 commits intorelease/1.7+labringfrom
Conversation
…figuration Signed-off-by: Yun Pan <dinoallo@netc.it>
Signed-off-by: Yun Pan <dinoallo@netc.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
make protosby:find -exec rm -f {}) to avoidrmrunning with no args.protobuildpasses an include path that matches absolute proto filenames by using a temporaryProtobuild.tomlcontaining the repo root..protofiles.bin/during generation.These changes allow
make protosto run successfully in a developer environment. Please review; I can split the changes into separate commits or adjust the PR target if needed.