-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/video tags #27 #51
base: main
Are you sure you want to change the base?
Conversation
@@ -25,5 +25,6 @@ GOOGLE_ID = x | |||
GOOGLE_SECRET = x | |||
|
|||
# Only needed if you are using Github login | |||
# For local development, use http://localhost:3000 as the homepage URL and http://localhost:3000/oauth/github/callback as the callback URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit of extra documentation to help with project setup
message: [`Class not ${!!req.params.id ? "updated" : "added"}`], | ||
}; | ||
} finally { | ||
res.redirect(`/class/edit/${req.params.id}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When submitting an "edit class" form, it redirected to a new blank form, this redirects back to the same class
@@ -85,6 +85,7 @@ | |||
@apply text-right; | |||
} | |||
#timestamps, | |||
#tags, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i be checking in src/assets/css/index.css
?
Thank you so much! I'm in school all week so it might be a bit before I can review and merge. |
Tests are included in #53 |
TL;DR: Please make the tag feature fully server-side or just let me know why the client side code is necessary. 2 and 3 are optional. Please revert the change in lessons.js > addEditLesson() that redirects to /edit on submit -- I'll put up a separate issue for that. The comments in the .env file should have been a separate PR but don't bother as it's small, we'll just leave it here. |
From my perspective, the adding of the
Will revert all the changes in 4 and make the changes in 3 |
closes #27
Added filtering by tags
/class/filter
which can be accessed by clicking on any tagImages
Tags on all classes page
Tags in each class
Edit tags
Select filters
Select multiple filters