Implement circuit breaker #129
Open
+331
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldas
reviewed
Mar 26, 2025
circuitbreaker/README.md
Outdated
| } | ||
|
|
||
| e := echo.New() | ||
| e.Use(circuitbreaker.CircuitBreakerMiddleware(cbConfig)) |
There was a problem hiding this comment.
This example would be better if middleware is added to the route.
aldas
reviewed
Mar 26, 2025
circuitbreaker/circuit_breaker.go
Outdated
| failureCount int | ||
| successCount int | ||
| state CircuitBreakerState | ||
| mutex sync.Mutex |
There was a problem hiding this comment.
sync.RWMutex would be probably more appropriate here
aldas
reviewed
Mar 26, 2025
circuitbreaker/circuit_breaker.go
Outdated
| ResetTimeout time.Duration // Interval for monitoring the circuit state | ||
| SuccessReset int // Number of successful attempts to move to closed state | ||
| OnOpen func(ctx echo.Context) error // Callback for open state | ||
| OnHalfOpen func(ctx echo.Context) error // Callback for half-open state |
There was a problem hiding this comment.
some of these callbacks are not used
aldas
reviewed
Mar 26, 2025
circuitbreaker/circuit_breaker.go
Outdated
| func (cb *CircuitBreaker) monitorReset() { | ||
| for { | ||
| select { | ||
| case <-time.After(cb.resetTimeout): |
There was a problem hiding this comment.
Probably time.NewTicker https://pkg.go.dev/time#example-NewTicker would be more suitable
aldas
reviewed
Mar 26, 2025
circuitbreaker/circuit_breaker.go
Outdated
| cb.failureCount = 0 // Reset failure count | ||
| } | ||
| cb.mutex.Unlock() | ||
| case <-cb.exitChan: |
There was a problem hiding this comment.
where is this chan used so we could receive something here?
|
@aldas I've made changes, can you please check again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Circuit Breaker Middleware
@aldas @jrhrmsll @lammel Would appreciate it if you can review this PR.