Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arabic language added #8202

Closed
wants to merge 1 commit into from
Closed

Arabic language added #8202

wants to merge 1 commit into from

Conversation

mucan54
Copy link
Contributor

@mucan54 mucan54 commented Jun 18, 2023

Arabic language added

@bhanu2217 bhanu2217 added this to the v2.0.3 milestone Jun 18, 2023
@Sabaric12 Sabaric12 self-requested a review June 19, 2023 11:10
Sabaric12
Sabaric12 approved these changes Jun 19, 2023
View reviewed changes
Copy link

@Sabaric12 Sabaric12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this pr with the fresh installation
Now the new Language named as arabic as added
Before Fix
Screenshot from 2023-06-19 16-40-04
After Fix
Screenshot from 2023-06-19 16-40-53

@Sabaric12 Sabaric12 added the QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed label Jun 19, 2023
@bhanu2217 bhanu2217 added the PD: Demo approval required Developer has to give a demo to the Product team after dev completion and only then raise PR label Aug 28, 2023
@Dhayanan Dhayanan self-requested a review August 31, 2023 06:45
@bhanu2217
Copy link
Contributor

bhanu2217 commented Aug 31, 2023 •
edited by DhanyaChengappa
Loading

Demo feedback:

Screenshot 2023-08-31 at 1 22 13 PM

@bhanu2217 bhanu2217 added PD: Demo corrections Developer is working on Demo feedback and removed PD: Demo approval required Developer has to give a demo to the Product team after dev completion and only then raise PR Requires Functionality Review labels Aug 31, 2023
@Noor-mommadhi Noor-mommadhi self-assigned this Aug 31, 2023
@Dhayanan Dhayanan added the QA: Round 2 Testing In Progress Second round of testing in progress label Sep 8, 2023
@Dhayanan
Copy link

Dhayanan commented Sep 8, 2023

Tested this PR existing DB on local :-
Second round test summary:-
Total time in days: 6 hours
Total issues: 44
Minor - 44
Major - 0
Critical - 0
Functionality correction :-1
Issue document:-
https://docs.google.com/document/d/1dlr6eRTl6fmlNXbYsc0QyjjKncYxsJkYc6LeBOCuxs8/edit

@Dhayanan Dhayanan added Functionality Correction and removed QA: Round 2 Testing In Progress Second round of testing in progress labels Sep 8, 2023
@KNaveenraj-ladybird
Copy link
Contributor

Further changes and functionality corrections would be done in this PR: - #8245 . So i am closing this pr

@KNaveenraj-ladybird KNaveenraj-ladybird mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabaric12 Sabaric12 Sabaric12 approved these changes

@RafficMohammed RafficMohammed RafficMohammed approved these changes

@Dhayanan Dhayanan Awaiting requested review from Dhayanan

Assignees

@mucan54 mucan54

@Noor-mommadhi Noor-mommadhi

Labels
Code Approved Functionality Correction PD: Demo corrections Developer is working on Demo feedback QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@mucan54 @bhanu2217 @Dhayanan @KNaveenraj-ladybird @RafficMohammed @Sabaric12 @Noor-mommadhi