[WIP] Allow starting an environment from a remote init file #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for fetching the init file from an http or https server, i.e.: lago init http://localhost:8000/inits/LagoInitFile Signed-off-by: Nadav Goldin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for running
lago initwith the init file as a remote URL, i.e.:The use case is straight-forward: we could put several 'default' inits in http://templates.ovirt.org, and make them reusable. Also it will make "getting started with lago" much easier: install lago & run
lago init http://.....This raises 2 questions:
Should the downloaded init file be saved for future usage? Currently I implemented it so it is a temporary file(so it is not saved), in order to bypass the question of how to create 'unique' init files each time.
I'm not sure what to do with 'LAGO_INITFILE_PATH' which we normally set to the init file location. It doesn't make sense to set it to
/tmp, as the remote init file could use that variable. For now I set it to the path of where the 'lago init' command was called.Thoughts?
Signed-off-by: Nadav Goldin [email protected]