Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Solve some concurrency issues #621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Aug 20, 2017

  1. Use uuid4 instead of uuid1

    Until now the prefix uuid was generated with 'uuid1' command. In cases
    where you started two environments with the same network names - the uuid1 usage
    caused us to pass the same network name to libvirt, despite the environments being
    different, thus throwing a libvirt error.
    
    The reason is that we truncated the 8 last bytes of the uuid1 and joined
    that with the network name. The 8 last bytes of uuid1 are most
    definitely not random.
    I see no reason to have the uuid not completely random - therefore this
    patch changes the prefix uuid to be generated with uuid4, which should
    be completely random.
    
    Signed-off-by: Nadav Goldin <[email protected]>
    nvgoldin committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    4d8d2c4 View commit details
    Browse the repository at this point in the history
  2. prefix: change 'prefixed_name' logic

    This patch changes the 'prefixed_name' function logic, so it will
    generate unique names, based on the Prefix UUID4 and the SHA256 hash
    of the passed name.
    This is required as we use those names in passed network names to
    libvirt.
    
    Signed-off-by: Nadav Goldin <[email protected]>
    nvgoldin committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    f38a919 View commit details
    Browse the repository at this point in the history
  3. virt: remove unused private methods

    Signed-off-by: Nadav Goldin <[email protected]>
    nvgoldin committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    37fa058 View commit details
    Browse the repository at this point in the history
  4. docs: add future package to mocking

    Signed-off-by: Nadav Goldin <[email protected]>
    nvgoldin committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    8a6f517 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Merge branch 'master' into uuid4

    Yaniv Kaul authored Apr 25, 2018
    Configuration menu
    Copy the full SHA
    b9aab68 View commit details
    Browse the repository at this point in the history