Conversation
Teolhyn
force-pushed
the
fix/share-calculations
branch
from
807d3a3 to
6cdf361
Compare
Teolhyn
force-pushed
the
fix/share-calculations
branch
from
54ff353 to
3c25afd
Compare
kovipu
approved these changes
Mar 12, 2025
Comment on lines
+744
to
+748
| // Move in time | ||
| e.ledger().with_mut(|li| { | ||
| li.sequence_number = 100_000 + 100_000; | ||
| li.timestamp = 1 + 31_556_926; | ||
| }); |
Member
There was a problem hiding this comment.
Could we make a helper function for this? Would improve readability and remove repetition.
| } | ||
|
|
||
| #[test] | ||
| #[should_panic(expected = "Error(Contract, #12)")] |
Member
There was a problem hiding this comment.
I'd love to make asserting errors a bit more readable. Now I have to look in error.rs to see what the hell is error #12. 😂
But I tried doing that with the try_ contract calls and asserting the Result, but couldn't get that to work. Maybe we'll have to let this marinate for a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.