Repository navigation
API: turn away apps below the minimum compatibility level - #27
Merged
Merged
Conversation
Requests declaring an App-Compat-Level below the API's minimum get 400 app_outdated, and a header that isn't an integer gets 400 invalid_compat_level. Requests without the header pass. The level is added to the request log, to show which levels are still in use. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Follows Google's AIP-193, which maps FAILED_PRECONDITION to 400. 426 is meant for protocol upgrades, and the app acts on the error code anyway. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Caution No coverage for base commit d9d94a8 was found, so this report compares against its ancestor 5c15d2f (2 commits earlier) Merging this branch will increase overall coverage
Coverage detailsCompared to commit 5c15d2f (run #39268062149)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The API half of the API compatibility level, App baseline slice, item 4 in the roadmap (
specs/README.md). Requests declaring anApp-Compat-LevelbelowminAppCompatLevelget 400app_outdated, and a header that isn't an integer gets 400invalid_compat_level. Requests without the header pass, so nothing changes for the current app. The level is added to the request log. This also settles the open decision on the status: 400, following AIP-193.The app's header and "Update required" screen follow in the next PR.
Size
About 47 logic lines (
compat.go43, plus 2 one-line edits).How to review
Start with
api/internal/server/compat.go. The wiring is one line inserver.goand one log field inmiddleware.go. The docs only record the 400 decision.Testing
make fmt lint testpasses.compat_test.gocovers no header, the minimum, above it, below it, negative and non-integer.🤖 Generated with Claude Code