Repository navigation
Fix the release APK signing check and speed up the build - #31
Merged
Merged
Conversation
apksigner doesn't always label the signer "Signer #1", so the check found no digest and refused a correctly signed APK. Print apksigner's output too, and fail on an apksigner error instead of hiding it behind sed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiling React Native's native code for all four ABIs made up most of the 23-minute build. Every phone the app targets is 64-bit ARM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lakaniemi
force-pushed
the
fix/apk-signing-check
branch
from
November 10, 2026 16:10
3c07f18 to
805ccb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The first
app-releaserun built a signed APK but failed the signing check: apksigner's signer label didn't matchSigner #1, so no digest was found. That run also took 23 minutes to build. This fixes the check and makes the build faster and bounded. Follow-up to the App baseline slice (#29).Size
~15 lines, all in
.github/workflows/app-release.yml, plus a line inapp/docs/ARCHITECTURE.md.How to review
One commit per change:
Signer…label, print apksigner's output, useshell: bashso an apksigner error fails the step instead of hiding behindsed.arm64-v8a: every phone the app runs on is 64-bit ARM. Documented inapp/docs/ARCHITECTURE.md.gradle/actions/setup-gradle@v6.timeout-minutes: 45on the release job.Testing
Not run yet: the workflow only runs on
main. After merging, re-runapp-releaseby hand (workflow_dispatch). Noapp-v<version>tag exists yet, so it releases the current version.🤖 Generated with Claude Code