Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bench comment #1060

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix bench comment #1060

merged 1 commit into from
Jan 21, 2025

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 17, 2025

I was getting triggered by this (image) and fixed it

image

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Jan 17, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.915 ± 0.043 3.864 4.012 1.00
base dict_insert.cairo (AOT) 4.124 ± 0.063 4.026 4.227 1.05 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 4.038 ± 0.042 3.992 4.104 1.00
head dict_insert.cairo (AOT) 4.279 ± 0.035 4.228 4.324 1.06 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.874 ± 0.045 3.814 3.968 1.00
base dict_snapshot.cairo (AOT) 4.050 ± 0.032 3.995 4.089 1.05 ± 0.01

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 3.778 ± 0.019 3.755 3.815 1.00
head dict_snapshot.cairo (AOT) 3.983 ± 0.039 3.952 4.085 1.05 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.256 ± 0.052 4.201 4.382 1.00
base factorial_2M.cairo (AOT) 4.397 ± 0.041 4.329 4.454 1.03 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 4.136 ± 0.028 4.086 4.179 1.00
head factorial_2M.cairo (AOT) 4.397 ± 0.044 4.339 4.473 1.06 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.658 ± 0.032 3.591 3.710 1.00
base fib_2M.cairo (AOT) 3.867 ± 0.014 3.844 3.888 1.06 ± 0.01

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 3.710 ± 0.035 3.656 3.763 1.00
head fib_2M.cairo (AOT) 3.905 ± 0.034 3.853 3.968 1.05 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.885 ± 0.041 3.832 3.944 1.00
base linear_search.cairo (AOT) 4.014 ± 0.040 3.953 4.073 1.03 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 3.891 ± 0.034 3.839 3.944 1.00
head linear_search.cairo (AOT) 4.020 ± 0.029 3.983 4.075 1.03 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.983 ± 0.061 3.871 4.043 1.00
base logistic_map.cairo (AOT) 4.123 ± 0.059 4.054 4.236 1.04 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 4.029 ± 0.036 3.994 4.095 1.00
head logistic_map.cairo (AOT) 4.181 ± 0.032 4.123 4.219 1.04 ± 0.01

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (965e3f9) to head (7188336).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1060   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         108      108           
  Lines       29938    29938           
=======================================
  Hits        24237    24237           
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 17, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.918 ± 0.151 20.761 21.226 100.08 ± 2.30
cairo-native (embedded AOT) 4.073 ± 0.043 4.030 4.155 19.49 ± 0.47
cairo-native (embedded JIT using LLVM's ORC Engine) 3.898 ± 0.019 3.870 3.932 18.65 ± 0.42
cairo-native (standalone AOT with -march=native) 0.209 ± 0.005 0.202 0.217 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.953 ± 0.080 5.873 6.145 3041.06 ± 81.63
cairo-native (embedded AOT) 4.073 ± 0.040 3.996 4.134 2080.69 ± 52.53
cairo-native (embedded JIT using LLVM's ORC Engine) 3.918 ± 0.049 3.851 3.995 2001.47 ± 52.79
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.863 ± 0.073 14.780 15.011 10.94 ± 0.07
cairo-native (embedded AOT) 4.398 ± 0.030 4.364 4.451 3.24 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 4.173 ± 0.034 4.132 4.238 3.07 ± 0.03
cairo-native (standalone AOT with -march=native) 1.358 ± 0.006 1.354 1.375 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.800 ± 0.081 14.701 14.928 183.38 ± 1.13
cairo-native (embedded AOT) 3.831 ± 0.046 3.789 3.919 47.47 ± 0.59
cairo-native (embedded JIT using LLVM's ORC Engine) 3.698 ± 0.060 3.619 3.795 45.82 ± 0.76
cairo-native (standalone AOT with -march=native) 0.081 ± 0.000 0.080 0.081 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.930 ± 0.084 5.832 6.123 2968.61 ± 275.89
cairo-native (embedded AOT) 3.971 ± 0.028 3.922 4.008 1988.16 ± 183.15
cairo-native (embedded JIT using LLVM's ORC Engine) 3.889 ± 0.076 3.748 3.997 1946.85 ± 182.81
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.006 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.679 ± 0.043 5.610 5.762 23.30 ± 0.39
cairo-native (embedded AOT) 4.019 ± 0.032 3.959 4.061 16.49 ± 0.28
cairo-native (embedded JIT using LLVM's ORC Engine) 3.947 ± 0.030 3.892 4.002 16.19 ± 0.27
cairo-native (standalone AOT with -march=native) 0.244 ± 0.004 0.242 0.255 1.00

@edg-l edg-l marked this pull request as ready for review January 17, 2025 14:08
@edg-l edg-l added the review-ready A PR that is ready for review label Jan 20, 2025
@edg-l edg-l added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit ecb0c82 Jan 21, 2025
56 checks passed
@edg-l edg-l deleted the fix_benchcomment branch January 21, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants