Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update melior #1061

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update melior #1061

wants to merge 2 commits into from

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 20, 2025

This new melior update allows more flexibility with blocks

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Jan 20, 2025

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.870 ± 0.034 3.831 3.925 1.00
base dict_insert.cairo (AOT) 4.022 ± 0.013 3.996 4.039 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.842 ± 0.025 3.798 3.877 1.00
head dict_insert.cairo (AOT) 4.032 ± 0.037 3.984 4.112 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.755 ± 0.010 3.739 3.772 1.00
base dict_snapshot.cairo (AOT) 3.894 ± 0.026 3.866 3.951 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 3.738 ± 0.016 3.713 3.769 1.00
head dict_snapshot.cairo (AOT) 3.875 ± 0.030 3.834 3.923 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.110 ± 0.019 4.060 4.124 1.00
base factorial_2M.cairo (AOT) 4.330 ± 0.039 4.275 4.421 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.088 ± 0.024 4.042 4.121 1.00
head factorial_2M.cairo (AOT) 4.311 ± 0.023 4.265 4.343 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.661 ± 0.022 3.621 3.685 1.00
base fib_2M.cairo (AOT) 3.849 ± 0.027 3.799 3.904 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.620 ± 0.014 3.586 3.639 1.00
head fib_2M.cairo (AOT) 3.838 ± 0.018 3.812 3.879 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.818 ± 0.020 3.777 3.851 1.00
base linear_search.cairo (AOT) 3.954 ± 0.043 3.896 4.053 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.818 ± 0.028 3.783 3.861 1.00
head linear_search.cairo (AOT) 3.962 ± 0.048 3.920 4.061 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.931 ± 0.022 3.906 3.984 1.00
base logistic_map.cairo (AOT) 4.027 ± 0.033 3.992 4.097 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.924 ± 0.019 3.895 3.957 1.00
head logistic_map.cairo (AOT) 4.003 ± 0.027 3.959 4.037 1.02 ± 0.01

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (0befa7c) to head (b4011c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         108      108           
  Lines       29938    29938           
=======================================
  Hits        24237    24237           
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 20, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.853 ± 0.126 20.674 21.037 107.09 ± 1.69
cairo-native (embedded AOT) 3.991 ± 0.038 3.954 4.090 20.50 ± 0.36
cairo-native (embedded JIT using LLVM's ORC Engine) 3.800 ± 0.016 3.780 3.838 19.52 ± 0.30
cairo-native (standalone AOT with -march=native) 0.195 ± 0.003 0.192 0.204 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.836 ± 0.060 5.761 5.915 3083.28 ± 211.56
cairo-native (embedded AOT) 3.841 ± 0.023 3.798 3.871 2029.61 ± 138.25
cairo-native (embedded JIT using LLVM's ORC Engine) 3.711 ± 0.027 3.674 3.754 1960.82 ± 133.81
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.004 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.809 ± 0.136 14.642 15.128 10.91 ± 0.10
cairo-native (embedded AOT) 4.369 ± 0.034 4.325 4.425 3.22 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 4.116 ± 0.048 4.068 4.206 3.03 ± 0.04
cairo-native (standalone AOT with -march=native) 1.357 ± 0.004 1.355 1.367 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.653 ± 0.104 14.544 14.916 183.13 ± 1.42
cairo-native (embedded AOT) 3.817 ± 0.038 3.756 3.879 47.70 ± 0.50
cairo-native (embedded JIT using LLVM's ORC Engine) 3.623 ± 0.056 3.553 3.706 45.27 ± 0.71
cairo-native (standalone AOT with -march=native) 0.080 ± 0.000 0.080 0.081 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.789 ± 0.030 5.753 5.851 2875.07 ± 66.23
cairo-native (embedded AOT) 4.038 ± 0.055 3.941 4.094 2005.37 ± 52.57
cairo-native (embedded JIT using LLVM's ORC Engine) 3.906 ± 0.034 3.859 3.976 1939.76 ± 46.80
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.727 ± 0.057 5.654 5.852 23.65 ± 0.24
cairo-native (embedded AOT) 4.078 ± 0.041 4.028 4.137 16.84 ± 0.17
cairo-native (embedded JIT using LLVM's ORC Engine) 3.965 ± 0.046 3.889 4.054 16.37 ± 0.19
cairo-native (standalone AOT with -march=native) 0.242 ± 0.000 0.242 0.243 1.00

@edg-l edg-l added the review-ready A PR that is ready for review label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants