Do NOT expand path to support special characters in path.

[lambdalisue]

For example, React Router v7 with file-based routing use $paramName in path and that is not environment variable.

Summary by CodeRabbit

• Bug Fixes
  • Improved how the current buffer path is determined when no path is provided, ensuring more accurate path resolution.

[coderabbitai]

Walkthrough

The ensurePath function in denops/gin/util/ensure_path.ts was updated to use fn.bufname() instead of fn.expand("%") when resolving the current buffer name if no path is provided. The conversion to an absolute path remains unchanged.

Changes

File(s)	Change Summary
denops/gin/util/ensure_path.ts	Updated ensurePath to use fn.bufname() for buffer name resolution instead of fn.expand("%").

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ensurePath
    participant fn

    Caller->>ensurePath: call (path?)
    alt path is provided
        ensurePath->>fn: fn.fnamemodify(path, ":p")
    else path is not provided
        ensurePath->>fn: fn.bufname()
        ensurePath->>fn: fn.fnamemodify(bufname, ":p")
    end
    ensurePath-->>Caller: return absolute path

Loading

Possibly related PRs

• 👍 Make path of GinChaperon and GinPatch optional #141: Modifies command logic to use the same ensurePath function for handling optional paths, directly relating to the updated resolution logic.

Poem

A path to find, a buffer's name,
The code has changed, but stays the same.
From expand to bufname, a subtle shift,
Ensuring paths with a gentle lift.
Hop, hop! The rabbit cheers,
For tidy code through all the years. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70b2116 and 78ecf1d.

📒 Files selected for processing (1)

• denops/gin/util/ensure_path.ts (1 hunks)

🔇 Additional comments (1)

denops/gin/util/ensure_path.ts (1)

18-18: LGTM! Correct fix for preventing unwanted expansion of special characters.

The change from fn.expand("%") to fn.bufname(denops) properly addresses the issue where path parameters containing special characters like $paramName were being incorrectly interpreted and expanded as environment variables. This fix ensures that paths with special characters are preserved as-is while still allowing the subsequent absolute path conversion to work correctly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.91%. Comparing base (70b2116) to head (78ecf1d).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   58.91%   58.91%           
=======================================
  Files          17       17           
  Lines         881      881           
  Branches      108      108           
=======================================
  Hits          519      519           
  Misses        362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.