Propery resolve from cwd in revParse function

[lambdalisue]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling for more accurate reporting of exceptions.
  • Enhanced path resolution to ensure correct handling of relative paths.

[coderabbitai]

Walkthrough

The changes update error handling in the findWorktree and findGitdir functions to check exception types before assignment, and adjust the revParse function to resolve paths relative to the provided working directory. No exported function signatures were modified.

Changes

File(s)	Change Summary
denops/gin/git/finder.ts	Updated error handling in findWorktree and findGitdir to check exception type; modified revParse to resolve paths relative to cwd.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant finder.ts

    Caller->>finder.ts: findWorktree()/findGitdir()
    alt Exception occurs
        finder.ts->>finder.ts: Check if exception is Error
        alt Is Error
            finder.ts-->>Caller: Assign to result
        else Not Error
            finder.ts-->>Caller: Rethrow exception
        end
    end
    Caller->>finder.ts: revParse(cwd, ...)
    finder.ts->>finder.ts: resolve(cwd, outputLine)
    finder.ts-->>Caller: Return resolved path

Loading

Possibly related PRs

• Fix worktree detection for worktrees inside .git directory #154: Refactored findWorktree and revParse to add upward traversal and worktree root detection, which this PR further refines in error handling and path resolution.

Poem

In the warren of code, I hop with delight,
Catching errors with care, not just any fright.
Paths now resolve where you want them to go,
With a twitch of my nose, git roots I now know.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b564a2e and 48cc19c.

📒 Files selected for processing (1)

• denops/gin/git/finder.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test (macos-latest, 1.x, v9.1.0448, v0.10.0)
• GitHub Check: test (windows-latest, 1.45.0, v9.1.0448, v0.10.0)
• GitHub Check: test (ubuntu-latest, 1.x, v9.1.0448, v0.10.0)
• GitHub Check: test (ubuntu-latest, 1.45.0, v9.1.0448, v0.10.0)
• GitHub Check: test (macos-latest, 1.45.0, v9.1.0448, v0.10.0)
• GitHub Check: test (windows-latest, 1.x, v9.1.0448, v0.10.0)

🔇 Additional comments (3)

denops/gin/git/finder.ts (3)

48-54: LGTM! Improved error handling with type safety.

The change from unconditional casting to explicit instanceof Error checking is a good defensive programming practice. This prevents potential runtime issues when non-Error values are thrown.

---

76-82: LGTM! Consistent error handling improvement.

This applies the same defensive error handling pattern as in findWorktree, ensuring consistent and safe exception handling throughout the module.

---

110-110: Excellent fix! Properly resolves paths relative to the working directory.

This change correctly addresses the PR objective by ensuring git paths are resolved relative to the provided cwd rather than the process's current directory. This is crucial for proper path resolution in git operations, especially when working with different repositories or worktrees.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.30%. Comparing base (b564a2e) to head (48cc19c).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
denops/gin/git/finder.ts	45.45%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   60.61%   60.30%   -0.32%     
==========================================
  Files          17       17              
  Lines         904      912       +8     
  Branches      118      120       +2     
==========================================
+ Hits          548      550       +2     
- Misses        356      362       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.