Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX num_points parameter deprecation in imagepolygon() #24

Merged
merged 3 commits into from
Jun 13, 2024
Merged

FIX num_points parameter deprecation in imagepolygon() #24

merged 3 commits into from
Jun 13, 2024

Conversation

ls-youssef-jlidat
Copy link
Contributor

@ls-youssef-jlidat ls-youssef-jlidat commented May 10, 2024 •
edited
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

The parameter num_points has been deprecated in PHP 8.1
https://www.php.net/manual/en/function.imagepolygon.php

Error [8192]: imagepolygon(): Using the $num_points parameter is deprecated in /var/www/vendor/laminas/laminas-barcode/src/Renderer/Image.php on line 501

@ls-youssef-jlidat ls-youssef-jlidat mentioned this pull request May 10, 2024
Closed
froschdesign
froschdesign requested changes May 16, 2024
View reviewed changes
src/Renderer/Image.php Outdated Show resolved Hide resolved
@froschdesign froschdesign added the Bug Something isn't working label May 16, 2024
@froschdesign froschdesign linked an issue May 16, 2024 that may be closed by this pull request
Deprecated Functionality: imagepolygon(): Using the $num_points parameter is deprecated PHP 8.1 #17
Closed
@ls-youssef-jlidat ls-youssef-jlidat force-pushed the fix-imagepolygon-deprecation branch from 94081b8 to 3c202b2 Compare May 16, 2024 14:50
@ls-youssef-jlidat
FIX num_points parameter deprecation in imagepolygon
cbc89f8 
The parameter `num_points` has been deprecated in PHP 8.1

Signed-off-by: Youssef JLIDAT <[email protected]>
@ls-youssef-jlidat
Remove PHP version check in imagepolygon() and imagefilledpolygon()
a835f3e 
Signed-off-by: Youssef JLIDAT <[email protected]>
@ls-youssef-jlidat ls-youssef-jlidat force-pushed the fix-imagepolygon-deprecation branch from 3c202b2 to a835f3e Compare May 16, 2024 15:06
@ls-youssef-jlidat
Copy link
Contributor Author

ls-youssef-jlidat commented Jun 13, 2024 •
edited
Loading

Hey @froschdesign, Is there any chance we could get this one merged soon? Thanks a bunch!

gsteel
gsteel approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ls-youssef-jlidat

@gsteel gsteel changed the base branch from 2.14.x to 2.13.x June 13, 2024 20:26
@gsteel gsteel changed the base branch from 2.13.x to 2.14.x June 13, 2024 20:28
@gsteel gsteel self-assigned this Jun 13, 2024
@gsteel gsteel added this to the 2.14.0 milestone Jun 13, 2024
@gsteel gsteel merged commit a442be8 into laminas:2.14.x Jun 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsteel gsteel gsteel approved these changes

@froschdesign froschdesign Awaiting requested review from froschdesign

Assignees

@gsteel gsteel

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

Deprecated Functionality: imagepolygon(): Using the $num_points parameter is deprecated PHP 8.1
3 participants
@ls-youssef-jlidat @froschdesign @gsteel