Merge pull request #156 from IonBazan/bugfix/final-class-reflection

Fix generating final classes from reflection
laminas · Nov 21, 2022 · 91aabc0 · 91aabc0
2 parents 0337d92 + 281746e
commit 91aabc0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Generator/ClassGenerator.php b/src/Generator/ClassGenerator.php
@@ -85,6 +85,7 @@ public static function fromReflection(ClassReflection $classReflection)
         }
 
         $cg->setAbstract($classReflection->isAbstract());
+        $cg->setFinal($classReflection->isFinal());
 
         // set the namespace
         if ($classReflection->inNamespace()) {

diff --git a/test/Generator/ClassGeneratorTest.php b/test/Generator/ClassGeneratorTest.php
@@ -1395,7 +1395,7 @@ public function testClassWithPromotedParameterFromReflection(): void
         $expectedOutput = <<<EOS
 namespace LaminasTest\Code\Generator\TestAsset;
 
-class ClassWithPromotedParameter
+final class ClassWithPromotedParameter
 {
     public function __construct(private string \$promotedParameter)
     {