This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Use lowercase config key to get configuration from container
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1 Signed-off-by: Michał Bundyra <[email protected]>
samsonasik
approved these changes
Apr 18, 2020
samsonasik
added a commit
that referenced
this pull request
Apr 18, 2020
Forward port #7 * michalbundyra-hotfix/lowercase-config-key-sm: Updates copyright notes Set version constraint for replaced repository in composer.json Adds .github directory into .gitattributes Require specific repository_dispatch event type - docs-build Use lowercase `config` key to get configuration from container
Member
|
@michalbundyra Thank you, merged to master, forward port to develop. |
Member
|
Just wondering... isn't this a BC break for laminas? AFAIK |
Member
|
@geerteltink for laminas-mvc, there is alias for that https://github.com/laminas/laminas-mvc/blob/e3c420a96349f57655ed28b135290e331edb579c/src/Service/ServiceListenerFactory.php#L39-L41 |
Member
|
Ah cool, I didn't know that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of zendframework/zend-config#66
Fixes #1