Merge pull request #225 from pine3ree/3.12.x-get-out-of-the-loop

Move array values string type-casting out of the loop
laminas · Jun 26, 2023 · 263d186 · 263d186
2 parents 193b2e5 + 749d67d
commit 263d186
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/View/Helper/FormSelect.php b/src/View/Helper/FormSelect.php
@@ -161,6 +161,8 @@ public function renderOptions(array $options, array $selectedOptions = []): stri
         $optionStrings = [];
         $escapeHtml    = $this->getEscapeHtmlHelper();
 
+        $stringSelectedOptions = array_map('strval', $selectedOptions);
+
         foreach ($options as $key => $optionSpec) {
             $value    = '';
             $label    = '';
@@ -192,7 +194,6 @@ public function renderOptions(array $options, array $selectedOptions = []): stri
                 $disabled = $optionSpec['disabled'];
             }
 
-            $stringSelectedOptions = array_map('\\strval', $selectedOptions);
             if (ArrayUtils::inArray((string) $value, $stringSelectedOptions, true)) {
                 $selected = true;
             }