General type inference improvements #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal here was to get inference when iterating over a form or fieldset, both for psalm and in yer IDE - this led to fixing a few more psalm issues here and there. There are a couple of additions to the baseline occurring due to improved inference, but it would have been unwise to fix these. Signed-off-by: George Steel <[email protected]>
gsteel
commented
Nov 19, 2023
Comment on lines
-304
to
+309
| if ( | ||
| empty($messageSet) | ||
| || (! is_array($messageSet) && ! $messageSet instanceof Traversable) | ||
| ) { | ||
| if ($messageSet === []) { |
There was a problem hiding this comment.
ElementInterface::getMessages() has a native array return type
Ocramius
approved these changes
Nov 20, 2023
| @@ -203,13 +207,14 @@ public function has(string $elementOrFieldset): bool | |||
| */ | |||
| public function get(string $elementOrFieldset): ElementInterface | |||
| { | |||
| if (! $this->has($elementOrFieldset)) { | |||
| $element = $this->iterator->get($elementOrFieldset); | |||
There was a problem hiding this comment.
Is this behaviour change safe to perform? 🤔
There was a problem hiding this comment.
Yes it is:
Lines 194 to 197 in b83d29b
Slamdunk
approved these changes
Nov 20, 2023
| @@ -203,13 +207,14 @@ public function has(string $elementOrFieldset): bool | |||
| */ | |||
| public function get(string $elementOrFieldset): ElementInterface | |||
| { | |||
| if (! $this->has($elementOrFieldset)) { | |||
| $element = $this->iterator->get($elementOrFieldset); | |||
There was a problem hiding this comment.
Yes it is:
Lines 194 to 197 in b83d29b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here was to get inference when iterating over a form or fieldset, both for psalm and in yer IDE - this led to fixing a few more psalm issues here and there.
There are a couple of additions to the baseline occurring due to improved inference, but it would have been unwise to fix these.