Add failing test case for factory creation of elements with required options #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to use custom elements with required options via configuration, i.e.
This can be fixed in Factory by passing any options found in
$spec
but this reveals more problematic issues with collections, for example. Because the options are given to the Collection at construction time, it creates the nested element(s) before the factory has been injected (via setter injection in the plugin manager initialisers) - This causes a fresh plugin manager to be created inside the collection with a call to->get('NestedElement')
for an unknown element (By default the plugin manager will auto add an invokable factory).