Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Laminas Coding Standard to ~3.0 #127

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Upgrade Laminas Coding Standard to ~3.0 #127

merged 1 commit into from
Nov 13, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Nov 13, 2024

Q A
QA yes

@gsteel gsteel added Dependencies Updates and changes to dependencies QA Quality assurance tasks such as static analysis improvements labels Nov 13, 2024
@gsteel gsteel added this to the 4.16.0 milestone Nov 13, 2024
@gsteel gsteel self-assigned this Nov 13, 2024
@gsteel
Copy link
Member Author

gsteel commented Nov 13, 2024

Merging without review - only CS fixes are applied to tests

froschdesign
froschdesign approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel merged commit a162bd5 into laminas:4.16.x Nov 13, 2024
15 checks passed
@gsteel gsteel deleted the lcs-3 branch November 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign approved these changes

Assignees

@gsteel gsteel

Labels
Dependencies Updates and changes to dependencies QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @froschdesign