Skip to content

Conversation

@qidian99
Copy link

Fix #119

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@chatgpt-codex-connector
Copy link

💡 Codex Review

override def setNull(): Unit = {
// mark the parent struct as null for this row
valueVector.setNull(count)
}

P1 Badge Propagate struct null rows to children

When a struct column contains null rows, setNull only clears the parent validity bit and never advances the child writers, while setValue now marks later rows as defined. After a null struct row the parent’s count increments but the children’s counts stay behind, so subsequent non-null structs are reported as valid but their children reside at earlier indexes (or are absent), leading to misaligned data or IndexOutOfBounds when consumers read the record batch. setNull needs to also write nulls for each child to keep child value counts aligned with the parent for every row.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@qidian99 qidian99 changed the title Fix struct fix: set struct parent validity when writing struct for lance v2.1+ Nov 24, 2025
@github-actions github-actions bot added the bug Something isn't working label Nov 24, 2025
@qidian99 qidian99 force-pushed the fix_struct branch 3 times, most recently from c181f14 to c6d6d30 Compare November 24, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: struct columns written for lance format v2.1/v2.2 is always null

1 participant