FFI error and shared caches#53
Merged
Merged
Conversation
Simplify error conversions in parse_file(). Fix ENOTDIR mapping in parse_directory() and add tests. Signed-off-by: Mickaël Salaün <mic@digikod.net>
Do not use the commit ID to avoid almost duplicated caches. GitHub CI caches are only shared for the same PR and can be imported from the main branch. GitHub CI cache is limited to 10 GB, a Rust build cache is ~1150 MB, and an Arch Linux container cache is ~960 MB. Signed-off-by: Mickaël Salaün <mic@digikod.net>
l0kod
force-pushed
the
ffi-error-and-shared-caches
branch
from
6dabb3e to
e7ba982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit improves errno conversion, and the second commit widely share caches. Both commits are useful in the same PR to verify that the caches work correctly.
This shared cache should help to reduce the number of caches, especially with #52