Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default MariaDB version to 10.6, resolves lando/mariadb#25. #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update default MariaDB version to 10.6, resolves lando/mariadb#25. #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions services/mariadb/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ const _ = require('lodash');
module.exports = {
name: 'mariadb',
config: {
version: '10.3',
supported: ['10.6', '10.5', '10.4', '10.3', '10.2', '10.1'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing versions should not be removed from the supported array. If you remove this, for people who use these versions, Lando will result to ERROR ==> mariadb version 10.2 is not supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaszarobert Tormi put versions 10.3 and below into the legacy array, so it'd just flash a warning that users are on old versions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reynoldsalec: We would want to keep 10.3 in the supported array and remove from the legacy array, right?

legacy: ['10.1'],
version: '10.6',
supported: ['10.6', '10.5', '10.4'],
legacy: ['10.3', '10.2', '10.1'],
pinPairs: {
'10.6': 'bitnami/mariadb:10.6.5-debian-10-r30',
'10.5': 'bitnami/mariadb:10.5.8-debian-10-r74',
Expand Down