-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve composer version defaults #137
Conversation
❌ Deploy Preview for lando-php failed. Why did it fail? →
|
That sounds like a great idea. Scratching my head on why the tests are borking with the "UNeedSetup", was noticing on that on a little PR I was working on. |
I think it's something with the latest edge version. This should allow us to manually run tests against alternate release channels once it's merged: #138 |
Yeah something is definitely busted on edge, getting the same error across a bunch of different plugins. |
fdaa7c9
to
1504875
Compare
This is now working as expected. Composer 2.8.2 has since been released so I updated that to be the default for newer PHP versions. I also discovered and fixed a bug where I left the preinstalled versions in the images alone for now and will address those in #119 |
c6b2b32
to
a015cf6
Compare
39b2c5b
to
d35ae2a
Compare
This reverts commit 6e0c309.
4d7b0da
to
284dfd4
Compare
284dfd4
to
f3af1cb
Compare
Some newer things, e.g. Symfony 7 Console, aren't compatible with old composer. Old PHP is not compatible with new composer.
This PR updates the default Composer version from 2.2.22 to 2.8.2, with additional logic to set the defaults to the appropriate LTS versions for older PHP versions.
I also updated patch versions of Composer in the images.