Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve composer version defaults #137

Merged
merged 17 commits into from
Dec 18, 2024
Merged

Improve composer version defaults #137

merged 17 commits into from
Dec 18, 2024

Conversation

AaronFeledy
Copy link
Member

@AaronFeledy AaronFeledy commented Oct 21, 2024

Some newer things, e.g. Symfony 7 Console, aren't compatible with old composer. Old PHP is not compatible with new composer.

This PR updates the default Composer version from 2.2.22 to 2.8.2, with additional logic to set the defaults to the appropriate LTS versions for older PHP versions.

I also updated patch versions of Composer in the images.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for lando-php failed. Why did it fail? →

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/lando-php/deploys/67630a1fd148ba295e75d586

@reynoldsalec
Copy link
Member

That sounds like a great idea. Scratching my head on why the tests are borking with the "UNeedSetup", was noticing on that on a little PR I was working on.

@AaronFeledy
Copy link
Member Author

I think it's something with the latest edge version. This should allow us to manually run tests against alternate release channels once it's merged: #138

@reynoldsalec
Copy link
Member

Yeah something is definitely busted on edge, getting the same error across a bunch of different plugins.

@AaronFeledy AaronFeledy force-pushed the composer-versions branch 6 times, most recently from fdaa7c9 to 1504875 Compare October 30, 2024 00:08
@AaronFeledy
Copy link
Member Author

AaronFeledy commented Oct 30, 2024

This is now working as expected. Composer 2.8.2 has since been released so I updated that to be the default for newer PHP versions. I also discovered and fixed a bug where composer_version: 1 with a number instead of a string would always install 2.2.x.

I left the preinstalled versions in the images alone for now and will address those in #119

@AaronFeledy AaronFeledy force-pushed the composer-versions branch 2 times, most recently from 39b2c5b to d35ae2a Compare December 4, 2024 04:02
@AaronFeledy AaronFeledy force-pushed the composer-versions branch 4 times, most recently from 4d7b0da to 284dfd4 Compare December 17, 2024 19:32
@reynoldsalec reynoldsalec merged commit fd0419d into main Dec 18, 2024
57 of 61 checks passed
@reynoldsalec reynoldsalec deleted the composer-versions branch December 18, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants