Skip to content

fixed ssl termination service from incorrectly reporting as a legacy …#48

Merged
pirog merged 3 commits intomainfrom
legacy-warnings
Jan 18, 2025
Merged

fixed ssl termination service from incorrectly reporting as a legacy …#48
pirog merged 3 commits intomainfrom
legacy-warnings

Conversation

@pirog
Copy link
Copy Markdown
Member

@pirog pirog commented Jan 18, 2025

…version

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

@pirog pirog marked this pull request as ready for review January 18, 2025 13:16
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 18, 2025

Deploy Preview for lando-varnish ready!

Name Link
🔨 Latest commit 14191db
🔍 Latest deploy log https://app.netlify.com/sites/lando-varnish/deploys/678bab1f2f689000084e30f9
😎 Deploy Preview https://deploy-preview-48--lando-varnish.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pirog pirog merged commit 922510c into main Jan 18, 2025
@pirog pirog deleted the legacy-warnings branch January 18, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant