Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: apply prettier #238

Merged
merged 3 commits into from
Feb 21, 2024
Merged

style: apply prettier #238

merged 3 commits into from
Feb 21, 2024

Conversation

totto2727
Copy link
Contributor

Summary

Continued from #237

Currently, the number of PRs is relatively small, and this is an opportunity to apply them collectively.

Concerns.

Ongoing tasks need to Rebase or Merge. Conflicts are likely to occur and will require a certain time cost to resolve.

It is also possible that a large number of conflicts may occur due to forking of other working contributors.

The project should be formatted as soon as possible, but we would like to ask for your judgment because of the risks mentioned above.

Countermeasures

After a quick check, "trailingComma": "es5" and "singleQuote": true may be needed.

Introducing these may reduce the differences.

@lane711
Copy link
Owner

lane711 commented Feb 16, 2024

Thank you again for your PR and for helping us cleanup the formatting

  1. can you please remove the trailing comma at the end of objects?
  2. please change double quotes to single quotes

@totto2727 totto2727 force-pushed the style/apply-prettier branch from 011a96f to 085e4a8 Compare February 17, 2024 05:43
@totto2727
Copy link
Contributor Author

Fixed!
What do you think?

If you prefer double quotation marks for CSS, etc., I will adjust it.

@totto2727
Copy link
Contributor Author

Fixed GitHub Actions triggers.
Fork-derived PRs will also fire.

@lane711
Copy link
Owner

lane711 commented Feb 20, 2024

yes we probably need to use double quotes for CSS. That seems to be most common

@totto2727
Copy link
Contributor Author

I understand.
Use the Override function to double-quote only CSS.

https://prettier.io/docs/en/configuration.html#configuration-overrides

 "overrides": [
   {
     "files": ["*.css"],
     "options": {
       singleQuote: false,
     }
   }
 ]

@lane711 lane711 merged commit 5e3e75c into lane711:main Feb 21, 2024
2 checks passed
@totto2727 totto2727 deleted the style/apply-prettier branch February 21, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants