simplify backend protocol #209
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
commented
Oct 27, 2025
| default: BackendProtocol | StateBackend, | ||
| routes: dict[str, BackendProtocol], | ||
| default: Backend, | ||
| routes: dict[str, Backend], |
Collaborator
Author
There was a problem hiding this comment.
Why is routes a dictionary? Why so general?
eyurtsev
commented
Oct 27, 2025
| ... | ||
| # Backend factory function types | ||
| BackendProvider = Callable[[ToolRuntime], Backend] | ||
| AsyncBackendProvider = Callable[[ToolRuntime], Awaitable[Backend]] |
Collaborator
Author
There was a problem hiding this comment.
We'll need async support at some point for all operations + the factory itself. Would suggest not adding it until we're ready to add full async support
eyurtsev
commented
Oct 27, 2025
| checkpointer: Checkpointer | None = None, | ||
| store: BaseStore | None = None, | ||
| backend: BackendProtocol | None = None, | ||
| backend: BackendProvider | None = None, |
Collaborator
Author
There was a problem hiding this comment.
This should be Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify backend protocol