Skip to content

Conversation

@tanghoong
Copy link

Introduces platform-specific handling for terminal input and external editor selection, enabling full Windows 11 support. The CLI now uses msvcrt for keyboard input on Windows and sets Notepad as the default editor, while the shell middleware defaults to PowerShell on Windows for improved compatibility. Documentation is updated to reflect these changes and provide installation guidance for Windows users.

)

Introduces platform-specific handling for terminal input and external editor selection, enabling full Windows 11 support. The CLI now uses msvcrt for keyboard input on Windows and sets Notepad as the default editor, while the shell middleware defaults to PowerShell on Windows for improved compatibility. Documentation is updated to reflect these changes and provide installation guidance for Windows users.
Copilot AI review requested due to automatic review settings November 1, 2025 10:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Windows platform support to DeepAgents by implementing platform-specific terminal handling and shell configuration. The changes enable the CLI to work seamlessly on Windows 11 by adapting to platform differences in terminal control, keyboard input, and shell commands.

Key changes:

  • Platform-specific terminal control using msvcrt on Windows instead of termios/tty
  • PowerShell as the default shell on Windows (instead of bash)
  • Platform-appropriate default editor selection (notepad vs nano)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
libs/deepagents/middleware/resumable_shell.py Adds __init__ method to configure PowerShell as the default shell on Windows
libs/deepagents-cli/deepagents_cli/execution.py Refactors interactive approval logic into platform-specific implementations using msvcrt for Windows
libs/deepagents-cli/deepagents_cli/input.py Sets platform-appropriate default editor (notepad on Windows, nano on Unix)
libs/deepagents-cli/deepagents_cli/ui.py Updates help text to display the correct default editor for the current platform
README.md Documents Windows 11 compatibility and platform-specific dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eyurtsev
Copy link
Collaborator

eyurtsev commented Nov 3, 2025

We'd need to set up testing for this on CI for windows machines

@tanghoong
Copy link
Author

We'd need to set up testing for this on CI for windows machines

Yes, I noticed that some behaviors still need improvement during the 'approval' and 'rejected' actions in the CLI.

@yangysc
Copy link

yangysc commented Nov 5, 2025

I really need the windows support since the text editor would crush on windows. Hope this can be merged ASAP...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants