-
Notifications
You must be signed in to change notification settings - Fork 809
fix: Add Windows compatibility for CLI and shell tools (#259) #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
) Introduces platform-specific handling for terminal input and external editor selection, enabling full Windows 11 support. The CLI now uses msvcrt for keyboard input on Windows and sets Notepad as the default editor, while the shell middleware defaults to PowerShell on Windows for improved compatibility. Documentation is updated to reflect these changes and provide installation guidance for Windows users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Windows platform support to DeepAgents by implementing platform-specific terminal handling and shell configuration. The changes enable the CLI to work seamlessly on Windows 11 by adapting to platform differences in terminal control, keyboard input, and shell commands.
Key changes:
- Platform-specific terminal control using
msvcrton Windows instead oftermios/tty - PowerShell as the default shell on Windows (instead of bash)
- Platform-appropriate default editor selection (notepad vs nano)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
libs/deepagents/middleware/resumable_shell.py |
Adds __init__ method to configure PowerShell as the default shell on Windows |
libs/deepagents-cli/deepagents_cli/execution.py |
Refactors interactive approval logic into platform-specific implementations using msvcrt for Windows |
libs/deepagents-cli/deepagents_cli/input.py |
Sets platform-appropriate default editor (notepad on Windows, nano on Unix) |
libs/deepagents-cli/deepagents_cli/ui.py |
Updates help text to display the correct default editor for the current platform |
README.md |
Documents Windows 11 compatibility and platform-specific dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
We'd need to set up testing for this on CI for windows machines |
Yes, I noticed that some behaviors still need improvement during the 'approval' and 'rejected' actions in the CLI. |
|
I really need the windows support since the text editor would crush on windows. Hope this can be merged ASAP... |
Introduces platform-specific handling for terminal input and external editor selection, enabling full Windows 11 support. The CLI now uses msvcrt for keyboard input on Windows and sets Notepad as the default editor, while the shell middleware defaults to PowerShell on Windows for improved compatibility. Documentation is updated to reflect these changes and provide installation guidance for Windows users.