fix(modal): pass explicit auth credentials to ModalClient#667
Open
Paul (paul-atx) wants to merge 1 commit into
Open
fix(modal): pass explicit auth credentials to ModalClient#667Paul (paul-atx) wants to merge 1 commit into
Paul (paul-atx) wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 7b54d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Paul (@paul-atx) is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
deepagents-acp
deepagents
@langchain/sandbox-standard-tests
@langchain/daytona
@langchain/deno
@langchain/modal
@langchain/node-vfs
@langchain/quickjs
commit: |
initialize(), fromId() and fromName() called getAuthCredentials() only to
validate that credentials exist, discarded the result, and constructed
`new ModalClient()` with no arguments. Credentials supplied through the
documented `auth: { tokenId, tokenSecret }` option were therefore ignored,
and the client fell back to env vars / .modal.toml, failing with "Profile
is missing token_id or token_secret" when no env/config profile is present.
Capture the resolved credentials and pass them to ModalClient.
Paul (paul-atx)
force-pushed
the
fix/modal-auth-credentials-ignored
branch
from
20401a6 to
7b54d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModalSandboxvalidates auth credentials but never passes them to the client.initialize(),fromId(), andfromName()callgetAuthCredentials(...)only to confirm credentials exist, discard the return value, and constructnew ModalClient()with no arguments.As a result, credentials supplied through the documented
auth: { tokenId, tokenSecret }option are ignored —ModalClientfalls back toMODAL_TOKEN_*env vars /.modal.toml. If no env/config profile is present, the first API call fails with "Profile is missing token_id or token_secret" despite valid credentials having been provided.Changes
getAuthCredentials(...)and pass them tonew ModalClient({ tokenId, tokenSecret })ininitialize(),fromId(), andfromName().Test plan
authoption now reaches the Modal client; env-var auth is unchanged.@langchain/modalunit tests.