Skip to content

feat(middleware): document new retry_model_request hook #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat(middleware): document new retry_model_request hook #747

wants to merge 5 commits into from

Conversation

@christian-bromann
Copy link
Member

Copilot AI review requested due to automatic review settings October 6, 2025 11:24
@github-actions github-actions bot added langchain For docs changes to LangChain oss labels Oct 6, 2025
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR documents the new retry_model_request hook functionality for LangChain middleware, which allows middleware to handle model execution failures and implement retry logic with modified parameters.

Key changes:

  • Documents the new retry_model_request/retryModelRequest hook for both Python and JavaScript
  • Adds comprehensive documentation for the new ModelFallbackMiddleware that uses this hook
  • Updates middleware execution order documentation to include retry behavior

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Preview ID generated: preview-cbretr-1759749913-4c2b387

lnhsingh
lnhsingh approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@lnhsingh lnhsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but otherwise looks good

@christian-bromann @lnhsingh
Update src/oss/langchain/middleware.mdx
d5616b3 
Co-authored-by: Lauren Hirata Singh <[email protected]>
Copilot AI review requested due to automatic review settings October 7, 2025 08:28
@christian-bromann @lnhsingh
Update src/oss/langchain/middleware.mdx
9bb4659 
Co-authored-by: Lauren Hirata Singh <[email protected]>
Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Preview ID generated: preview-cbretr-1759825760-5ab4575

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Preview ID generated: preview-cbretr-1759826112-955d806

Copilot AI review requested due to automatic review settings October 7, 2025 08:37
Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

src/oss/langchain/middleware.mdx
```python
from langchain.agents import create_agent
from langchain.agents.middleware import AgentState, ModelRequest, modify_model_request
from langchain.agents.middleware.types import AgentState, ModelRequest, modify_model_request
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been changed from langchain.agents.middleware to langchain.agents.middleware.types. This appears to be a breaking change that should be highlighted in the documentation or migration guide, as existing code using the old import path will fail.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Preview ID generated: preview-cbretr-1759826292-33b6b4e

@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 7, 2025

Standby as we might be changing this hook to on_model_call

@eyurtsev
Copy link
Collaborator

eyurtsev commented Oct 7, 2025

langchain-ai/langchain#33328

eyurtsev
eyurtsev requested changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll replace with on_model_call interceptor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@eyurtsev eyurtsev eyurtsev requested changes

@lnhsingh lnhsingh lnhsingh approved these changes

@katmayb katmayb Awaiting requested review from katmayb

Assignees

No one assigned

Labels

langchain For docs changes to LangChain oss

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christian-bromann @eyurtsev @lnhsingh @sydney-runkle