added vectara tools#30693
Closed
Adeel Ehsan (adeelehsan) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
added vectara tools#30693Adeel Ehsan (adeelehsan) wants to merge 1 commit intolangchain-ai:masterfrom
Adeel Ehsan (adeelehsan) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| name="vectara_search", | ||
| description="Search for information in the Vectara corpus", | ||
| vectorstore=vectara, | ||
| corpus_key="your-corpus-id" |
Contributor
There was a problem hiding this comment.
should be "your-corpus-key" not "your-corpus-id".
does it support multiple corpora?
| corpus_config = CorpusConfig( | ||
| corpus_key="your-corpus-id", | ||
| metadata_filter="doc.type = 'article'", | ||
| lexical_interpolation=0.2 |
Contributor
There was a problem hiding this comment.
Let's use the default 0.005
| name="vectara_generation", | ||
| description="Generate summaries from your Vectara corpus", | ||
| vectorstore=vectara, | ||
| corpus_key="your-corpus-id" # Optional, can be provided in config |
Contributor
There was a problem hiding this comment.
Same here - "your-corpus-key"
| return f"Error generating response from Vectara: {str(e)}" | ||
|
|
||
|
|
||
| class VectaraIngest(BaseVectorStoreTool, BaseTool): |
Contributor
There was a problem hiding this comment.
If we are doing "ingest" then why not also add "upload" tool? (for files like PDFs, DOC, etc)?
Collaborator
|
Could you move the code to langchain_vectara and only add the integration docs to langchain? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17.